view target-utils/libcommon/defgetchar.c @ 964:a96cb97b66a2

ringtools/imy: fix duplicate definition of tdma_durations[] The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>, although the present fix is slightly different from the contributed patch: because main.c doesn't need this tdma_durations[] array at all, let's simply remove the reference to this array from main.c rather than turn it into an extern. I no longer remember my original thought flow that resulted (by mistake) in tdma_durations[] being multiply defined in main.c and durations.c. My intent might have been to define all globals in main.c and have the reference in durations.c be an extern - and I missed that extern - but without clear memory, I have no certainty. In any case, having this data array defined in the same module that fills it (durations.c) is sensible, so let's make it the new way.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 31 Aug 2023 19:38:18 +0000
parents f9d2ce6591b7
children
line wrap: on
line source

/*
 * The interactive command entry (editing) function in libcommon
 * will call mygetchar() for its character input.  It is supposed
 * to be a blocking wait for input, but in some programs other
 * processing can be done while waiting - for example, check for
 * keypad presses as well.  This is the basic version which waits
 * for serial input and nothing else - specific programs can
 * override it if necessary, but this library version is the default.
 */

extern int serial_in_poll();

int
mygetchar()
{
	register int c;

	do
		c = serial_in_poll();
	while (c < 0);
	return c;
}