annotate target-utils/libcommon/defgetchar.c @ 964:a96cb97b66a2

ringtools/imy: fix duplicate definition of tdma_durations[] The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>, although the present fix is slightly different from the contributed patch: because main.c doesn't need this tdma_durations[] array at all, let's simply remove the reference to this array from main.c rather than turn it into an extern. I no longer remember my original thought flow that resulted (by mistake) in tdma_durations[] being multiply defined in main.c and durations.c. My intent might have been to define all globals in main.c and have the reference in durations.c be an extern - and I missed that extern - but without clear memory, I have no certainty. In any case, having this data array defined in the same module that fills it (durations.c) is sensible, so let's make it the new way.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 31 Aug 2023 19:38:18 +0000
parents f9d2ce6591b7
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
519
f9d2ce6591b7 target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 /*
f9d2ce6591b7 target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 * The interactive command entry (editing) function in libcommon
f9d2ce6591b7 target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 * will call mygetchar() for its character input. It is supposed
f9d2ce6591b7 target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 * to be a blocking wait for input, but in some programs other
f9d2ce6591b7 target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 * processing can be done while waiting - for example, check for
f9d2ce6591b7 target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 * keypad presses as well. This is the basic version which waits
f9d2ce6591b7 target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 * for serial input and nothing else - specific programs can
f9d2ce6591b7 target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 * override it if necessary, but this library version is the default.
f9d2ce6591b7 target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 */
f9d2ce6591b7 target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10
f9d2ce6591b7 target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 extern int serial_in_poll();
f9d2ce6591b7 target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12
f9d2ce6591b7 target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 int
f9d2ce6591b7 target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 mygetchar()
f9d2ce6591b7 target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 {
f9d2ce6591b7 target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 register int c;
f9d2ce6591b7 target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17
f9d2ce6591b7 target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 do
f9d2ce6591b7 target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 c = serial_in_poll();
f9d2ce6591b7 target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 while (c < 0);
f9d2ce6591b7 target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 return c;
f9d2ce6591b7 target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 }