changeset 265:e57bfdadf49a

mmiIcons.c: fix bogus icnType in incoming_call_animate[] The incoming call animation icons are actually drawn in 256-color format, but they were incorrectly declared as BMP_FORMAT_32BIT_COLOUR in the incoming_call_animate[] array. Why were they still getting displayed correctly despite this bogosity? Answer: because the mmi_dialogs_animation_new_CB() function overrides the icon bitmap type to 0x02, which means 256-color format. Needless to say, the icon format should be made correct at the source of the data, and at some later point we may need to remove the override from the animation display function.
author Mychaela Falconia <>
date Mon, 17 May 2021 07:18:36 +0000
parents 00107c0b8570
children 160a5b3a076c
files src/ui/bmi/mmiIcons.c
diffstat 1 files changed, 4 insertions(+), 4 deletions(-) [+]
line wrap: on
line diff
--- a/src/ui/bmi/mmiIcons.c	Fri May 14 06:01:34 2021 +0000
+++ b/src/ui/bmi/mmiIcons.c	Mon May 17 07:18:36 2021 +0000
@@ -1786,10 +1786,10 @@
 const MfwIcnAttr incoming_call_animate [CALLANIMATION] = {
-	{{40,5,100,80},1,COLOUR_ICON_XX,BMP_FORMAT_32BIT_COLOUR, (char *)callAnimation1},
-	{{40,5,100,80},1,COLOUR_ICON_XX,BMP_FORMAT_32BIT_COLOUR, (char *)callAnimation2},
-	{{40,5,100,80},1,COLOUR_ICON_XX,BMP_FORMAT_32BIT_COLOUR, (char *)callAnimation3},
-	{{40,5,100,80},1,COLOUR_ICON_XX,BMP_FORMAT_32BIT_COLOUR, (char *)callAnimation2}
+	{{40,5,100,80},1,COLOUR_ICON_XX,BMP_FORMAT_256_COLOUR, (char *)callAnimation1},
+	{{40,5,100,80},1,COLOUR_ICON_XX,BMP_FORMAT_256_COLOUR, (char *)callAnimation2},
+	{{40,5,100,80},1,COLOUR_ICON_XX,BMP_FORMAT_256_COLOUR, (char *)callAnimation3},
+	{{40,5,100,80},1,COLOUR_ICON_XX,BMP_FORMAT_256_COLOUR, (char *)callAnimation2}