comparison src/ui/bmi/mmiIcons.c @ 265:e57bfdadf49a

mmiIcons.c: fix bogus icnType in incoming_call_animate[] The incoming call animation icons are actually drawn in 256-color format, but they were incorrectly declared as BMP_FORMAT_32BIT_COLOUR in the incoming_call_animate[] array. Why were they still getting displayed correctly despite this bogosity? Answer: because the mmi_dialogs_animation_new_CB() function overrides the icon bitmap type to 0x02, which means 256-color format. Needless to say, the icon format should be made correct at the source of the data, and at some later point we may need to remove the override from the animation display function.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 17 May 2021 07:18:36 +0000
parents 86375353219d
children
comparison
equal deleted inserted replaced
264:00107c0b8570 265:e57bfdadf49a
1784 1784
1785 #endif 1785 #endif
1786 1786
1787 #ifdef COLOURDISPLAY 1787 #ifdef COLOURDISPLAY
1788 const MfwIcnAttr incoming_call_animate [CALLANIMATION] = { 1788 const MfwIcnAttr incoming_call_animate [CALLANIMATION] = {
1789 {{40,5,100,80},1,COLOUR_ICON_XX,BMP_FORMAT_32BIT_COLOUR, (char *)callAnimation1}, 1789 {{40,5,100,80},1,COLOUR_ICON_XX,BMP_FORMAT_256_COLOUR, (char *)callAnimation1},
1790 {{40,5,100,80},1,COLOUR_ICON_XX,BMP_FORMAT_32BIT_COLOUR, (char *)callAnimation2}, 1790 {{40,5,100,80},1,COLOUR_ICON_XX,BMP_FORMAT_256_COLOUR, (char *)callAnimation2},
1791 {{40,5,100,80},1,COLOUR_ICON_XX,BMP_FORMAT_32BIT_COLOUR, (char *)callAnimation3}, 1791 {{40,5,100,80},1,COLOUR_ICON_XX,BMP_FORMAT_256_COLOUR, (char *)callAnimation3},
1792 {{40,5,100,80},1,COLOUR_ICON_XX,BMP_FORMAT_32BIT_COLOUR, (char *)callAnimation2} 1792 {{40,5,100,80},1,COLOUR_ICON_XX,BMP_FORMAT_256_COLOUR, (char *)callAnimation2}
1793 1793
1794 }; 1794 };
1795 1795
1796 #endif 1796 #endif
1797 #if(0) /* x0039928 - Lint warning removal */ 1797 #if(0) /* x0039928 - Lint warning removal */