src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.

#!/bin/sh

if [ -z "$BUILD_DIR" ]
then
	BUILD_DIR=build-sb
fi

if [ -z "$USE_STR2IND" ]
then
	USE_STR2IND=0
fi

if [ -z "$CHIPSET" ]
then
	CHIPSET=10
fi

if [ -z "$DSP" ]
then
	DSP=36
fi

if [ -z "$RF" ]
then
	RF=12
fi

if [ -z "$L1_DYN_DSP_DWNLD" ]
then
	L1_DYN_DSP_DWNLD=1
fi

if [ -z "$TCSENV" ]
then
	TCSENV=2
fi

case "$TCSENV" in
	2)
		CONDAT=condat2
		GPF=gpf2
		CDGINC=cdg211/cdginc
		CDGPRIM=cdg211/prim
		ACI=aci2
		;;
	3)
		CONDAT=condat3
		GPF=gpf3
		CDGINC=cdg-hybrid/cdginc
		CDGPRIM=cdg-hybrid/sap-inline
		ACI=g23m-aci
		;;
	*)
		echo "Error: bad TCSENV= setting" 1>&2
		exit 1
		;;
esac

if [ -z "$MMI" ]
then
	MMI=0
fi

GPRS=1
SRVC=1

export ACI BUILD_DIR CDGINC CDGPRIM CHIPSET CONDAT DSP GPF GPRS
export L1_DYN_DSP_DWNLD MMI RF SRVC USE_STR2IND

exec scripts/mk-component.sh "$@"