FreeCalypso > hg > fc-magnetite
annotate scripts/mkcomp-test.sh @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | 5fbcfd465de0 |
| children | 8cf3029429f3 |
| rev | line source |
|---|---|
| 10 | 1 #!/bin/sh |
| 2 | |
|
17
6323e661f2ed
added the ability to select different gpf and cdginc versions
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
3 if [ -z "$BUILD_DIR" ] |
|
6323e661f2ed
added the ability to select different gpf and cdginc versions
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
4 then |
|
6323e661f2ed
added the ability to select different gpf and cdginc versions
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
5 BUILD_DIR=build-sb |
|
6323e661f2ed
added the ability to select different gpf and cdginc versions
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
6 fi |
|
6323e661f2ed
added the ability to select different gpf and cdginc versions
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
7 |
|
6323e661f2ed
added the ability to select different gpf and cdginc versions
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
8 if [ -z "$USE_STR2IND" ] |
|
6323e661f2ed
added the ability to select different gpf and cdginc versions
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
9 then |
|
6323e661f2ed
added the ability to select different gpf and cdginc versions
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
10 USE_STR2IND=0 |
|
6323e661f2ed
added the ability to select different gpf and cdginc versions
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
11 fi |
|
6323e661f2ed
added the ability to select different gpf and cdginc versions
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
12 |
|
391
1da4c0cc9fc2
scripts/mkcomp-test.sh: default the new CHIPSET etc variables
Mychaela Falconia <falcon@freecalypso.org>
parents:
172
diff
changeset
|
13 if [ -z "$CHIPSET" ] |
|
1da4c0cc9fc2
scripts/mkcomp-test.sh: default the new CHIPSET etc variables
Mychaela Falconia <falcon@freecalypso.org>
parents:
172
diff
changeset
|
14 then |
|
1da4c0cc9fc2
scripts/mkcomp-test.sh: default the new CHIPSET etc variables
Mychaela Falconia <falcon@freecalypso.org>
parents:
172
diff
changeset
|
15 CHIPSET=10 |
|
1da4c0cc9fc2
scripts/mkcomp-test.sh: default the new CHIPSET etc variables
Mychaela Falconia <falcon@freecalypso.org>
parents:
172
diff
changeset
|
16 fi |
|
1da4c0cc9fc2
scripts/mkcomp-test.sh: default the new CHIPSET etc variables
Mychaela Falconia <falcon@freecalypso.org>
parents:
172
diff
changeset
|
17 |
|
1da4c0cc9fc2
scripts/mkcomp-test.sh: default the new CHIPSET etc variables
Mychaela Falconia <falcon@freecalypso.org>
parents:
172
diff
changeset
|
18 if [ -z "$DSP" ] |
|
1da4c0cc9fc2
scripts/mkcomp-test.sh: default the new CHIPSET etc variables
Mychaela Falconia <falcon@freecalypso.org>
parents:
172
diff
changeset
|
19 then |
|
1da4c0cc9fc2
scripts/mkcomp-test.sh: default the new CHIPSET etc variables
Mychaela Falconia <falcon@freecalypso.org>
parents:
172
diff
changeset
|
20 DSP=36 |
|
1da4c0cc9fc2
scripts/mkcomp-test.sh: default the new CHIPSET etc variables
Mychaela Falconia <falcon@freecalypso.org>
parents:
172
diff
changeset
|
21 fi |
|
1da4c0cc9fc2
scripts/mkcomp-test.sh: default the new CHIPSET etc variables
Mychaela Falconia <falcon@freecalypso.org>
parents:
172
diff
changeset
|
22 |
|
1da4c0cc9fc2
scripts/mkcomp-test.sh: default the new CHIPSET etc variables
Mychaela Falconia <falcon@freecalypso.org>
parents:
172
diff
changeset
|
23 if [ -z "$RF" ] |
|
1da4c0cc9fc2
scripts/mkcomp-test.sh: default the new CHIPSET etc variables
Mychaela Falconia <falcon@freecalypso.org>
parents:
172
diff
changeset
|
24 then |
|
1da4c0cc9fc2
scripts/mkcomp-test.sh: default the new CHIPSET etc variables
Mychaela Falconia <falcon@freecalypso.org>
parents:
172
diff
changeset
|
25 RF=12 |
|
1da4c0cc9fc2
scripts/mkcomp-test.sh: default the new CHIPSET etc variables
Mychaela Falconia <falcon@freecalypso.org>
parents:
172
diff
changeset
|
26 fi |
|
1da4c0cc9fc2
scripts/mkcomp-test.sh: default the new CHIPSET etc variables
Mychaela Falconia <falcon@freecalypso.org>
parents:
172
diff
changeset
|
27 |
|
1da4c0cc9fc2
scripts/mkcomp-test.sh: default the new CHIPSET etc variables
Mychaela Falconia <falcon@freecalypso.org>
parents:
172
diff
changeset
|
28 if [ -z "$L1_DYN_DSP_DWNLD" ] |
|
1da4c0cc9fc2
scripts/mkcomp-test.sh: default the new CHIPSET etc variables
Mychaela Falconia <falcon@freecalypso.org>
parents:
172
diff
changeset
|
29 then |
|
1da4c0cc9fc2
scripts/mkcomp-test.sh: default the new CHIPSET etc variables
Mychaela Falconia <falcon@freecalypso.org>
parents:
172
diff
changeset
|
30 L1_DYN_DSP_DWNLD=1 |
|
1da4c0cc9fc2
scripts/mkcomp-test.sh: default the new CHIPSET etc variables
Mychaela Falconia <falcon@freecalypso.org>
parents:
172
diff
changeset
|
31 fi |
|
1da4c0cc9fc2
scripts/mkcomp-test.sh: default the new CHIPSET etc variables
Mychaela Falconia <falcon@freecalypso.org>
parents:
172
diff
changeset
|
32 |
|
19
88f40f4c829f
condat2 vs. condat3 includes selection logic
Mychaela Falconia <falcon@freecalypso.org>
parents:
17
diff
changeset
|
33 if [ -z "$TCSENV" ] |
|
17
6323e661f2ed
added the ability to select different gpf and cdginc versions
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
34 then |
|
19
88f40f4c829f
condat2 vs. condat3 includes selection logic
Mychaela Falconia <falcon@freecalypso.org>
parents:
17
diff
changeset
|
35 TCSENV=2 |
|
17
6323e661f2ed
added the ability to select different gpf and cdginc versions
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
36 fi |
|
6323e661f2ed
added the ability to select different gpf and cdginc versions
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
37 |
|
19
88f40f4c829f
condat2 vs. condat3 includes selection logic
Mychaela Falconia <falcon@freecalypso.org>
parents:
17
diff
changeset
|
38 case "$TCSENV" in |
|
88f40f4c829f
condat2 vs. condat3 includes selection logic
Mychaela Falconia <falcon@freecalypso.org>
parents:
17
diff
changeset
|
39 2) |
|
88f40f4c829f
condat2 vs. condat3 includes selection logic
Mychaela Falconia <falcon@freecalypso.org>
parents:
17
diff
changeset
|
40 CONDAT=condat2 |
|
88f40f4c829f
condat2 vs. condat3 includes selection logic
Mychaela Falconia <falcon@freecalypso.org>
parents:
17
diff
changeset
|
41 GPF=gpf2 |
|
17
6323e661f2ed
added the ability to select different gpf and cdginc versions
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
42 CDGINC=cdg211/cdginc |
|
6323e661f2ed
added the ability to select different gpf and cdginc versions
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
43 CDGPRIM=cdg211/prim |
|
172
2c61607bb3e3
build system: pass ACI version for headers to the component recipes
Mychaela Falconia <falcon@freecalypso.org>
parents:
115
diff
changeset
|
44 ACI=aci2 |
|
17
6323e661f2ed
added the ability to select different gpf and cdginc versions
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
45 ;; |
|
19
88f40f4c829f
condat2 vs. condat3 includes selection logic
Mychaela Falconia <falcon@freecalypso.org>
parents:
17
diff
changeset
|
46 3) |
|
88f40f4c829f
condat2 vs. condat3 includes selection logic
Mychaela Falconia <falcon@freecalypso.org>
parents:
17
diff
changeset
|
47 CONDAT=condat3 |
|
88f40f4c829f
condat2 vs. condat3 includes selection logic
Mychaela Falconia <falcon@freecalypso.org>
parents:
17
diff
changeset
|
48 GPF=gpf3 |
|
422
5fbcfd465de0
mkcomp-test.sh: correct cdginc headers for the hybrid env
Mychaela Falconia <falcon@freecalypso.org>
parents:
391
diff
changeset
|
49 CDGINC=cdg-hybrid/cdginc |
|
5fbcfd465de0
mkcomp-test.sh: correct cdginc headers for the hybrid env
Mychaela Falconia <falcon@freecalypso.org>
parents:
391
diff
changeset
|
50 CDGPRIM=cdg-hybrid/sap-inline |
|
172
2c61607bb3e3
build system: pass ACI version for headers to the component recipes
Mychaela Falconia <falcon@freecalypso.org>
parents:
115
diff
changeset
|
51 ACI=g23m-aci |
|
17
6323e661f2ed
added the ability to select different gpf and cdginc versions
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
52 ;; |
|
6323e661f2ed
added the ability to select different gpf and cdginc versions
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
53 *) |
|
19
88f40f4c829f
condat2 vs. condat3 includes selection logic
Mychaela Falconia <falcon@freecalypso.org>
parents:
17
diff
changeset
|
54 echo "Error: bad TCSENV= setting" 1>&2 |
|
17
6323e661f2ed
added the ability to select different gpf and cdginc versions
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
55 exit 1 |
|
6323e661f2ed
added the ability to select different gpf and cdginc versions
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
56 ;; |
|
6323e661f2ed
added the ability to select different gpf and cdginc versions
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
57 esac |
|
6323e661f2ed
added the ability to select different gpf and cdginc versions
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
58 |
|
115
e0cf9a040fef
scripts/mkcomp-test.sh: allow MMI setting to be overridden
Mychaela Falconia <falcon@freecalypso.org>
parents:
19
diff
changeset
|
59 if [ -z "$MMI" ] |
|
e0cf9a040fef
scripts/mkcomp-test.sh: allow MMI setting to be overridden
Mychaela Falconia <falcon@freecalypso.org>
parents:
19
diff
changeset
|
60 then |
|
e0cf9a040fef
scripts/mkcomp-test.sh: allow MMI setting to be overridden
Mychaela Falconia <falcon@freecalypso.org>
parents:
19
diff
changeset
|
61 MMI=0 |
|
e0cf9a040fef
scripts/mkcomp-test.sh: allow MMI setting to be overridden
Mychaela Falconia <falcon@freecalypso.org>
parents:
19
diff
changeset
|
62 fi |
|
e0cf9a040fef
scripts/mkcomp-test.sh: allow MMI setting to be overridden
Mychaela Falconia <falcon@freecalypso.org>
parents:
19
diff
changeset
|
63 |
| 10 | 64 GPRS=1 |
| 65 SRVC=1 | |
| 66 | |
|
391
1da4c0cc9fc2
scripts/mkcomp-test.sh: default the new CHIPSET etc variables
Mychaela Falconia <falcon@freecalypso.org>
parents:
172
diff
changeset
|
67 export ACI BUILD_DIR CDGINC CDGPRIM CHIPSET CONDAT DSP GPF GPRS |
|
1da4c0cc9fc2
scripts/mkcomp-test.sh: default the new CHIPSET etc variables
Mychaela Falconia <falcon@freecalypso.org>
parents:
172
diff
changeset
|
68 export L1_DYN_DSP_DWNLD MMI RF SRVC USE_STR2IND |
| 10 | 69 |
| 70 exec scripts/mk-component.sh "$@" |
