# HG changeset patch # User Mychaela Falconia # Date 1672704738 0 # Node ID 452c1d5a62685827fea0c85442103751d0d2a64f # Parent 2254fa16ec5f76eba65d3825d72d3c72d79e2b85 libgsmefr BFI w/o data: emit zero output after decoder reset In real-life usage, each EFR decoder session will most likely begin with lots of BFI frames before the first real frame arrives. However, because the spec-defined home state of the decoder is speech rather than CN, our regular logic for BFI w/o data would have to feed pseudorandom noise to the decoder (in the "fixed codebook excitation pulses" part), which is silly to do at the beginning of the decoder session right out of reset. Therefore, let's check reset_flag_old, and if we are still in the reset state, simply emit zero output. diff -r 2254fa16ec5f -r 452c1d5a6268 libgsmefr/bfi_nodata.c --- a/libgsmefr/bfi_nodata.c Mon Jan 02 23:05:38 2023 +0000 +++ b/libgsmefr/bfi_nodata.c Tue Jan 03 00:12:18 2023 +0000 @@ -46,6 +46,10 @@ { int16_t params[EFR_NUM_PARAMS]; + if (st->reset_flag_old) { + memset(pcm_out, 0, sizeof(int16_t) * L_FRAME); + return; + } memset(params, 0, sizeof(int16_t) * EFR_NUM_PARAMS); if (st->rxdtx_ctrl & RX_SP_FLAG) random_bad_frame(st, params);