annotate dev/efr-bit-packing.c @ 242:f081a6850fb5

libgsmfrp: new refined implementation The previous implementation exhibited the following defects, which are now fixed: 1) The last received valid SID was cached forever for the purpose of handling future invalid SIDs - we could have received some valid SID ages ago, then lots of speech or NO_DATA, and if we then get an invalid SID, we would resurrect the last valid SID from ancient history - a bad design. In our new design, we handle invalid SID based on the current state, much like BFI. 2) GSM 06.11 spec says clearly that after the second lost SID (received BFI=1 && TAF=1 in CN state) we need to gradually decrease the output level, rather than jump directly to emitting silence frames - we previously failed to implement such logic. 3) Per GSM 06.12 section 5.2, Xmaxc should be the same in all 4 subframes in a SID frame. What should we do if we receive an otherwise valid SID frame with different Xmaxc? Our previous approach would replicate this Xmaxc oddity in every subsequent generated CN frame, which is rather bad. In our new design, the very first CN frame (which can be seen as a transformation of the SID frame itself) retains the original 4 distinct Xmaxc, but all subsequent CN frames are based on the Xmaxc from the last subframe of the most recent SID.
author Mychaela Falconia <falcon@freecalypso.org>
date Tue, 09 May 2023 05:16:31 +0000
parents 9639a44ae2e7
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
32
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 /*
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 * We would like to generate our EFR RTP frame packing and unpacking code
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 * using bitter and sweet utilities from libgsm, so we'll end up packing
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 * and unpacking EFR just like good old FR. However, because of our
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 * slightly different approach, entering the spec file for bitter and sweet
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 * manually would be tedious and error-prone, hence we are going to
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 * generate it with this program.
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 */
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 #include <stdio.h>
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 #include <stdlib.h>
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 #define PRM_NO 57
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 /* table from ETSI EFR code */
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 static const unsigned bitno[PRM_NO] =
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 {
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 7, 8, 9, 8, 6, /* LSP VQ */
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 9, 4, 4, 4, 4, 4, 4, 3, 3, 3, 3, 3, 5, /* first subframe */
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 6, 4, 4, 4, 4, 4, 4, 3, 3, 3, 3, 3, 5, /* second subframe */
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 9, 4, 4, 4, 4, 4, 4, 3, 3, 3, 3, 3, 5, /* third subframe */
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 6, 4, 4, 4, 4, 4, 4, 3, 3, 3, 3, 3, 5 /* fourth subframe */
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 };
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 main(argc, argv)
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 char **argv;
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 {
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 unsigned n;
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 printf("EFR_MAGIC\t4\n");
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 for (n = 0; n < PRM_NO; n++)
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 printf("params[%u]\t%u\n", n, bitno[n]);
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 exit(0);
9639a44ae2e7 dev: efr-bit-packing helper program
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 }