annotate libgsmhr1/bitter-voiced @ 581:e2d5cad04cbf

libgsmhr1 RxFE: store CN R0+LPC separately from speech In the original GSM 06.06 code the ECU for speech mode is entirely separate from the CN generator, maintaining separate state. (The main intertie between them is the speech vs CN state variable, distinguishing between speech and CN BFIs, in addition to the CN-specific function of distinguishing between initial and update SIDs.) In the present RxFE implementation I initially thought that we could use the same saved_frame buffer for both ECU and CN, overwriting just the first 4 params (R0 and LPC) when a valid SID comes in. However, I now realize it was a bad idea: the original code has a corner case (long sequence of speech-mode BFIs to put the ECU in state 6, then SID and CN-mode BFIs, then a good speech frame) that would be broken by that buffer reuse approach. We could eliminate this corner case by resetting the ECU state when passing through a CN insertion period, but doing so would needlessly increase the behavioral diffs between GSM 06.06 and our version. Solution: use a separate CN-specific buffer for CN R0+LPC parameters, and match the behavior of GSM 06.06 code in this regard.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 13 Feb 2025 10:02:45 +0000
parents 4d80730683d4
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
490
4d80730683d4 libgsmhr1: implement TS 101 318 packing and unpacking
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 ; This file is an input to the old 'bitter' utility from libgsm source
4d80730683d4 libgsmhr1: implement TS 101 318 packing and unpacking
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 ; package; it will be used to generate C code for TS 101 318 packing and
4d80730683d4 libgsmhr1: implement TS 101 318 packing and unpacking
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 ; unpacking. This version is for voiced modes.
4d80730683d4 libgsmhr1: implement TS 101 318 packing and unpacking
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
4d80730683d4 libgsmhr1: implement TS 101 318 packing and unpacking
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 params[0] 5 ; R0
4d80730683d4 libgsmhr1: implement TS 101 318 packing and unpacking
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 params[1] 11 ; LPC1
4d80730683d4 libgsmhr1: implement TS 101 318 packing and unpacking
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 params[2] 9 ; LPC2
4d80730683d4 libgsmhr1: implement TS 101 318 packing and unpacking
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 params[3] 8 ; LPC3
4d80730683d4 libgsmhr1: implement TS 101 318 packing and unpacking
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 params[4] 1 ; INT LPC
4d80730683d4 libgsmhr1: implement TS 101 318 packing and unpacking
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 params[5] 2 ; Mode
4d80730683d4 libgsmhr1: implement TS 101 318 packing and unpacking
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11
4d80730683d4 libgsmhr1: implement TS 101 318 packing and unpacking
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 ; subframe 1
4d80730683d4 libgsmhr1: implement TS 101 318 packing and unpacking
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 params[6] 8
4d80730683d4 libgsmhr1: implement TS 101 318 packing and unpacking
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 params[7] 9
4d80730683d4 libgsmhr1: implement TS 101 318 packing and unpacking
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 params[8] 5
4d80730683d4 libgsmhr1: implement TS 101 318 packing and unpacking
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16
4d80730683d4 libgsmhr1: implement TS 101 318 packing and unpacking
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 ; subframe 2
4d80730683d4 libgsmhr1: implement TS 101 318 packing and unpacking
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 params[9] 4
4d80730683d4 libgsmhr1: implement TS 101 318 packing and unpacking
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 params[10] 9
4d80730683d4 libgsmhr1: implement TS 101 318 packing and unpacking
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 params[11] 5
4d80730683d4 libgsmhr1: implement TS 101 318 packing and unpacking
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21
4d80730683d4 libgsmhr1: implement TS 101 318 packing and unpacking
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 ; subframe 3
4d80730683d4 libgsmhr1: implement TS 101 318 packing and unpacking
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 params[12] 4
4d80730683d4 libgsmhr1: implement TS 101 318 packing and unpacking
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 params[13] 9
4d80730683d4 libgsmhr1: implement TS 101 318 packing and unpacking
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 params[14] 5
4d80730683d4 libgsmhr1: implement TS 101 318 packing and unpacking
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26
4d80730683d4 libgsmhr1: implement TS 101 318 packing and unpacking
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 ; subframe 4
4d80730683d4 libgsmhr1: implement TS 101 318 packing and unpacking
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 params[15] 4
4d80730683d4 libgsmhr1: implement TS 101 318 packing and unpacking
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 params[16] 9
4d80730683d4 libgsmhr1: implement TS 101 318 packing and unpacking
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 params[17] 5