annotate libgsmefr/enc_wrap.c @ 581:e2d5cad04cbf

libgsmhr1 RxFE: store CN R0+LPC separately from speech In the original GSM 06.06 code the ECU for speech mode is entirely separate from the CN generator, maintaining separate state. (The main intertie between them is the speech vs CN state variable, distinguishing between speech and CN BFIs, in addition to the CN-specific function of distinguishing between initial and update SIDs.) In the present RxFE implementation I initially thought that we could use the same saved_frame buffer for both ECU and CN, overwriting just the first 4 params (R0 and LPC) when a valid SID comes in. However, I now realize it was a bad idea: the original code has a corner case (long sequence of speech-mode BFIs to put the ECU in state 6, then SID and CN-mode BFIs, then a good speech frame) that would be broken by that buffer reuse approach. We could eliminate this corner case by resetting the ECU state when passing through a CN insertion period, but doing so would needlessly increase the behavioral diffs between GSM 06.06 and our version. Solution: use a separate CN-specific buffer for CN R0+LPC parameters, and match the behavior of GSM 06.06 code in this regard.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 13 Feb 2025 10:02:45 +0000
parents 269d341db403
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
113
269d341db403 libgsmefr: implement main encoder wrapper
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 /*
269d341db403 libgsmefr: implement main encoder wrapper
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 * This module contains our EFR_encode_frame() function, which is the primary
269d341db403 libgsmefr: implement main encoder wrapper
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 * (most common, most useful) interface to our EFR encoder.
269d341db403 libgsmefr: implement main encoder wrapper
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 */
269d341db403 libgsmefr: implement main encoder wrapper
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5
269d341db403 libgsmefr: implement main encoder wrapper
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 #include "gsm_efr.h"
269d341db403 libgsmefr: implement main encoder wrapper
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7
269d341db403 libgsmefr: implement main encoder wrapper
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 void EFR_encode_frame(struct EFR_encoder_state *st, const int16_t *pcm_in,
269d341db403 libgsmefr: implement main encoder wrapper
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 uint8_t *frame, int *sp_out, int *vad_out)
269d341db403 libgsmefr: implement main encoder wrapper
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 {
269d341db403 libgsmefr: implement main encoder wrapper
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 int16_t params[EFR_NUM_PARAMS];
269d341db403 libgsmefr: implement main encoder wrapper
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 int sp;
269d341db403 libgsmefr: implement main encoder wrapper
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13
269d341db403 libgsmefr: implement main encoder wrapper
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 EFR_encode_params(st, pcm_in, params, &sp, vad_out);
269d341db403 libgsmefr: implement main encoder wrapper
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 EFR_params2frame(params, frame);
269d341db403 libgsmefr: implement main encoder wrapper
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 if (!sp)
269d341db403 libgsmefr: implement main encoder wrapper
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 EFR_insert_sid_codeword(frame);
269d341db403 libgsmefr: implement main encoder wrapper
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 if (sp_out)
269d341db403 libgsmefr: implement main encoder wrapper
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 *sp_out = sp;
269d341db403 libgsmefr: implement main encoder wrapper
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 }