annotate libtwamr/tls_flags.c @ 605:63f774192906

gsmhr_decoder_twts002_in(): set BFI=1 SID=1 for invalid SID When a received TW-TS-002 RTP payload indicates invalid SID, which of the 3 possible BFI/SID combinations should we pass to our internal ETSI-based speech decoder or TFO engine? Our original code passed BFI=0 SID=1, but upon further reflection, BFI=1 SID=1 is a better choice. In the corner case where received invalid SID is fed to a full decoder in homed state, setting BFI=1 allows that decoder to emit zeros on PCM and stay homed, instead of launching into full decoding.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 04 Dec 2025 21:01:46 +0000
parents dfb1f86541b2
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
38
38326102fc43 libgsmefr: beginning to integrate code from ETSI
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 /*
38326102fc43 libgsmefr: beginning to integrate code from ETSI
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 * Unfortunately the code we got from ETSI makes heavy use of two global
38326102fc43 libgsmefr: beginning to integrate code from ETSI
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 * Boolean flags named Carry and Overflow that function like equally named
38326102fc43 libgsmefr: beginning to integrate code from ETSI
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 * processor state flags on many CPU architectures. They are not part
38326102fc43 libgsmefr: beginning to integrate code from ETSI
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 * of persistent codec session state for either the encoder or the decoder,
38326102fc43 libgsmefr: beginning to integrate code from ETSI
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 * instead they are "short-term" globals much like UNIX errno.
38326102fc43 libgsmefr: beginning to integrate code from ETSI
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 *
38326102fc43 libgsmefr: beginning to integrate code from ETSI
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 * Given this unfortunate reality plus the natural desire to make our
252
57b4053559ff libtwamr: beginning of project
Mychaela Falconia <falcon@freecalypso.org>
parents: 38
diff changeset
9 * AMR library thread-safe (a transcoding MGW handling a large volume of
38
38326102fc43 libgsmefr: beginning to integrate code from ETSI
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 * simultaneous calls is exactly the kind of application that would benefit
38326102fc43 libgsmefr: beginning to integrate code from ETSI
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 * from utilitizing all CPU cores), our current workaround is to use
38326102fc43 libgsmefr: beginning to integrate code from ETSI
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 * thread-local storage.
38326102fc43 libgsmefr: beginning to integrate code from ETSI
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 */
38326102fc43 libgsmefr: beginning to integrate code from ETSI
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14
38326102fc43 libgsmefr: beginning to integrate code from ETSI
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 #include "typedef.h"
359
dfb1f86541b2 libtwamr/tls_flags.c: use namespace.h for the right prefix
Mychaela Falconia <falcon@freecalypso.org>
parents: 252
diff changeset
16 #include "namespace.h"
38
38326102fc43 libgsmefr: beginning to integrate code from ETSI
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17
359
dfb1f86541b2 libtwamr/tls_flags.c: use namespace.h for the right prefix
Mychaela Falconia <falcon@freecalypso.org>
parents: 252
diff changeset
18 __thread Flag Carry, Overflow;