FreeCalypso > hg > gsm-codec-lib
annotate libtwamr/dtx_common.h @ 477:4c9222d95647
libtwamr encoder: always emit frame->mode = mode;
In the original implementation of amr_encode_frame(), the 'mode' member
of the output struct was set to 0xFF if the output frame type is TX_NO_DATA.
This design was made to mimic the mode field (16-bit word) being set to
0xFFFF (or -1) in 3GPP test sequence format - but nothing actually depends
on this struct member being set in any way, and amr_frame_to_tseq()
generates the needed 0xFFFF on its own, based on frame->type being equal
to TX_NO_DATA.
It is simpler and more efficient to always set frame->mode to the actual
encoding mode in amr_encode_frame(), and this new behavior has already
been documented in doc/AMR-library-API description in anticipation of
the present change.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sat, 18 May 2024 22:30:42 +0000 |
| parents | 5a1d18542f8a |
| children |
| rev | line source |
|---|---|
|
407
5a1d18542f8a
libtwamr: integrate dtx_dec.c and dtx_enc.c
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
1 /* |
|
5a1d18542f8a
libtwamr: integrate dtx_dec.c and dtx_enc.c
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
2 * This header file contains some common definitions that have been |
|
5a1d18542f8a
libtwamr: integrate dtx_dec.c and dtx_enc.c
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
3 * factored out of dtx_enc.h; the original code used the construct of |
|
5a1d18542f8a
libtwamr: integrate dtx_dec.c and dtx_enc.c
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
4 * dtx_dec.h including dtx_enc.h, but in the opinion of this developer |
|
5a1d18542f8a
libtwamr: integrate dtx_dec.c and dtx_enc.c
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
5 * it is better to factor out the common bits. |
|
5a1d18542f8a
libtwamr: integrate dtx_dec.c and dtx_enc.c
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
6 */ |
|
5a1d18542f8a
libtwamr: integrate dtx_dec.c and dtx_enc.c
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
7 |
|
5a1d18542f8a
libtwamr: integrate dtx_dec.c and dtx_enc.c
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
8 #ifndef dtx_common_h |
|
5a1d18542f8a
libtwamr: integrate dtx_dec.c and dtx_enc.c
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
9 #define dtx_common_h |
|
5a1d18542f8a
libtwamr: integrate dtx_dec.c and dtx_enc.c
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
10 |
|
5a1d18542f8a
libtwamr: integrate dtx_dec.c and dtx_enc.c
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
11 /* |
|
5a1d18542f8a
libtwamr: integrate dtx_dec.c and dtx_enc.c
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
12 ******************************************************************************** |
|
5a1d18542f8a
libtwamr: integrate dtx_dec.c and dtx_enc.c
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
13 * LOCAL VARIABLES AND TABLES |
|
5a1d18542f8a
libtwamr: integrate dtx_dec.c and dtx_enc.c
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
14 ******************************************************************************** |
|
5a1d18542f8a
libtwamr: integrate dtx_dec.c and dtx_enc.c
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
15 */ |
|
5a1d18542f8a
libtwamr: integrate dtx_dec.c and dtx_enc.c
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
16 #define DTX_HIST_SIZE 8 |
|
5a1d18542f8a
libtwamr: integrate dtx_dec.c and dtx_enc.c
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
17 #define DTX_ELAPSED_FRAMES_THRESH (24 + 7 -1) |
|
5a1d18542f8a
libtwamr: integrate dtx_dec.c and dtx_enc.c
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
18 #define DTX_HANG_CONST 7 /* yields eight frames of SP HANGOVER */ |
|
5a1d18542f8a
libtwamr: integrate dtx_dec.c and dtx_enc.c
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
19 |
|
5a1d18542f8a
libtwamr: integrate dtx_dec.c and dtx_enc.c
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
20 #endif |
