# HG changeset patch
# User Mychaela Falconia <falcon@freecalypso.org>
# Date 1549843219 0
# Node ID 003e48f8ebe16dd4660ac58c7470d7ad87357de9
# Parent  88f7e4d0f0b3511f2ab971f5bc8bc6c1f3d4b1dc
rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel

I generally don't use NULL and use plain 0 instead, based on a "NULL
considered harmful" discussion on the classiccmp mailing list many aeons
ago (I couldn't find it, and I reason that it must have been 2005 or
earlier), but a recent complaint by a packager sent me searching, and I
found this:

https://ewontfix.com/11/

While I don't give a @#$% about "modern" systems and code-nazi tools,
I realized that passing a plain 0 as a pointer sentinel in execl is wrong
because it will break on systems where pointers are longer than the plain
int type.  Again, I don't give a @#$% about the abomination of x86_64 and
the like, but if anyone ever manages to port my code to something like a
PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0
as a function argument where a pointer is expected most definitely won't
work: if the most natural stack slot and SP alignment unit is 16 bits,
fitting an int, with longs and pointers taking up two such slots, then
the call stack will be totally wrong with a plain 0 passed for a pointer.
Casting the 0 to (char *) ought to be the most kosher solution for the
most retro systems possible.

diff -r 88f7e4d0f0b3 -r 003e48f8ebe1 rvinterf/etmsync/fsnew.c
--- a/rvinterf/etmsync/fsnew.c	Sun Feb 10 22:40:38 2019 +0000
+++ b/rvinterf/etmsync/fsnew.c	Mon Feb 11 00:00:19 2019 +0000
@@ -33,7 +33,7 @@
 		return(ERROR_UNIX);
 	}
 	if (!child) {
-		execl(compiletool, compiletool, asciisrc, tmpfile, 0);
+		execl(compiletool, compiletool, asciisrc, tmpfile, (char *) 0);
 		perror(compiletool);
 		_exit(ERROR_UNIX);
 	}