view uptools/sms-pdu-decode/pcm-sms-decode.c @ 964:a96cb97b66a2

ringtools/imy: fix duplicate definition of tdma_durations[] The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>, although the present fix is slightly different from the contributed patch: because main.c doesn't need this tdma_durations[] array at all, let's simply remove the reference to this array from main.c rather than turn it into an extern. I no longer remember my original thought flow that resulted (by mistake) in tdma_durations[] being multiply defined in main.c and durations.c. My intent might have been to define all globals in main.c and have the reference in durations.c be an extern - and I missed that extern - but without clear memory, I have no certainty. In any case, having this data array defined in the same module that fills it (durations.c) is sensible, so let's make it the new way.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 31 Aug 2023 19:38:18 +0000
parents 411d1cc14326
children
line wrap: on
line source

#include <sys/types.h>
#include <ctype.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <strings.h>
#include <unistd.h>

extern int ascii_ext_mode, global_hexdump_mode;
extern u_char pdu[176];
extern unsigned pdu_length;

static char *infname;
static FILE *inf;
static unsigned start_recno;

static char *msgtype[4] = {"received", "received unread", "sent",
			   "stored unsent"};

static
process_cmdline(argc, argv)
	char **argv;
{
	int c;
	extern int optind;

	while ((c = getopt(argc, argv, "ehsu")) != EOF)
		switch (c) {
		case 'e':
			ascii_ext_mode = 1;
			continue;
		case 'h':
			global_hexdump_mode = 1;
			continue;
		case 's':
			start_recno = 1;
			continue;
		case 'u':
			ascii_ext_mode = 2;
			continue;
		default:
			fprintf(stderr, "%s: invalid option\n", argv[0]);
			exit(1);
		}
	if (argc != optind + 1) {
		fprintf(stderr, "usage: %s [options] pcm-sms-binfile\n",
			argv[0]);
		exit(1);
	}
	infname = argv[optind];
}

main(argc, argv)
	char **argv;
{
	u_char record[176];
	unsigned recno;

	process_cmdline(argc, argv);
	inf = fopen(infname, "r");
	if (!inf) {
		perror(infname);
		exit(1);
	}
	pdu_length = 176;
	for (recno = start_recno; fread(record, sizeof record, 1, inf);
	     recno++) {
		if (record[0] & 1) {
			printf("Record #%u is %s message:\n", recno,
				msgtype[(record[0] >> 1) & 3]);
			bcopy(record + 1, pdu, 175);
			process_pdu(0, 1);
			putchar('\n');
		} else
			printf("Record #%u is empty\n\n", recno);
	}
	exit(0);
}