FreeCalypso > hg > freecalypso-tools
view uptools/sms-pdu-decode/Makefile @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Thu, 31 Aug 2023 19:38:18 +0000 |
| parents | 31e219088cd6 |
| children |
line wrap: on
line source
CC= gcc CFLAGS= -O2 PROGS= pcm-sms-decode sms-pdu-decode LIB= ../libcoding/libcoding.a OBJS0= pcm-sms-decode.o pdu-common.o ${LIB} OBJS1= pdu-common.o sms-pdu-decode.o ${LIB} INSTALL_PREFIX= /opt/freecalypso INSTBIN=${INSTALL_PREFIX}/bin all: ${PROGS} pcm-sms-decode: ${OBJS0} ${CC} ${CFLAGS} -o $@ ${OBJS0} sms-pdu-decode: ${OBJS1} ${CC} ${CFLAGS} -o $@ ${OBJS1} install: mkdir -p ${INSTBIN} install -c ${PROGS} ${INSTBIN} clean: rm -f ${PROGS} *.o *errs *.out
