FreeCalypso > hg > freecalypso-tools
view uptools/libcoding/number_encode.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | 7154a231e4b5 |
children |
line wrap: on
line source
/* * This library module implements the function that parses SMS destination * addresses given by the user and encodes them into the GSM 03.40 * TP-Destination-Address structure. */ #include <sys/types.h> #include <ctype.h> #include <stdlib.h> digit_char_to_gsm(ch) { switch (ch) { case '0': case '1': case '2': case '3': case '4': case '5': case '6': case '7': case '8': case '9': return (ch - '0'); case '*': return 0xA; case '#': return 0xB; case 'a': case 'b': case 'c': return (ch - 'a' + 0xC); case 'A': case 'B': case 'C': return (ch - 'A' + 0xC); } return (-1); } parse_and_encode_dest_addr(input, outbuf) char *input; u_char *outbuf; { char *cp, *endp; int d; u_char digits[20]; unsigned n; cp = input; if (*cp == '+') { outbuf[1] = 0x91; cp++; } else outbuf[1] = 0x81; if (digit_char_to_gsm(*cp) < 0) return(-1); n = 0; while ((d = digit_char_to_gsm(*cp)) >= 0) { cp++; if (n >= 20) return(-1); digits[n++] = d; } outbuf[0] = n; while (n < 20) digits[n++] = 0xF; if (*cp == ',') { cp++; if (!isdigit(*cp)) return(-1); outbuf[1] = strtoul(cp, &endp, 0); if (*endp) return(-1); } else if (*cp) return(-1); for (n = 0; n < 10; n++) outbuf[2+n] = (digits[n*2+1] << 4) | digits[n*2]; return(0); }