FreeCalypso > hg > freecalypso-tools
view uptools/libcoding/Makefile @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Thu, 31 Aug 2023 19:38:18 +0000 |
| parents | f023a1c187a9 |
| children | ec7e23d5151f |
line wrap: on
line source
CC= gcc CFLAGS= -O2 OBJS= alpha_addr.o decode_helpers.o grokdcs.o gsm7_decode.o \ gsm7_decode_qstring.o gsm7_decode_tables.o gsm7_encode.o \ gsm7_encode_table.o gsm7_pack.o gsm7_unpack.o gsmtime.o hexdecode.o \ hexdump.o hexencode.o number_decode.o number_encode.o scaddr.o \ sms_submit.o sms_submit8.o ucs2_bigend.o ucs2_decode.o utf8_decode.o \ utf8_decode2.o LIB= libcoding.a all: ${LIB} ${LIB}: ${OBJS} ar rcu $@ ${OBJS} ranlib $@ clean: rm -f *.[oa] errs
