FreeCalypso > hg > freecalypso-tools
view uptools/atcmd/settime.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | dc2fd8e6f42c |
children |
line wrap: on
line source
/* * This utility sends an AT+CCLK command to the GSM device to set its time * to the host's notion of local time. */ #include <time.h> #include <stdio.h> #include <stdlib.h> #include <unistd.h> #include "../../rvinterf/include/exitcodes.h" main(argc, argv) char **argv; { int c; extern int optind; time_t unixtime; struct tm *tm; char command[32]; while ((c = getopt(argc, argv, "B:np:RX:")) != EOF) if (!atinterf_cmdline_opt(c)) { /* error msg already printed */ exit(ERROR_USAGE); } if (argc != optind) { fprintf(stderr, "usage: %s [options]\n", argv[0]); exit(ERROR_USAGE); } atinterf_init(); time(&unixtime); tm = localtime(&unixtime); sprintf(command, "AT+CCLK=\"%02d/%02d/%02d,%02d:%02d:%02d%+03d\"", tm->tm_year % 100, tm->tm_mon + 1, tm->tm_mday, tm->tm_hour, tm->tm_min, tm->tm_sec, tm->tm_gmtoff / (15*60)); atinterf_exec_cmd_needok(command, (char *) 0, (void *) 0); exit(0); }