FreeCalypso > hg > freecalypso-tools
view target-utils/simtest/poll.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | d96ea6ae6aa5 |
children |
line wrap: on
line source
#include <sys/types.h> #include <strings.h> #include "types.h" #include "simregs.h" extern int serial_in_poll(); int enable_poll; void poll_sim_rx() { u32 drx; if (SIMREGS.stat & SIM_STAT_FEMPTY) return; drx = SIMREGS.drx & 0xFF; printf("%02X ", drx); } int mygetchar() { register int c; do { if (enable_poll) poll_sim_rx(); c = serial_in_poll(); } while (c < 0); return c; } void cmd_poll(argbulk) char *argbulk; { char *argv[2]; if (parse_args(argbulk, 1, 1, argv, 0) < 0) return; if (!strcmp(argv[0], "on")) enable_poll = 1; else if (!strcmp(argv[0], "off")) enable_poll = 0; else printf("ERROR: \"on\" or \"off\" argument expected\n"); }