FreeCalypso > hg > freecalypso-tools
view target-utils/pirexplore/flashid.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | e7502631a0f9 |
children |
line wrap: on
line source
#include "types.h" void cmd_flashid(argbulk) char *argbulk; { char *argv[2]; u32 base_addr; if (parse_args(argbulk, 1, 1, argv, 0) < 0) return; if (argv[0][0] == '1' && !argv[0][1]) base_addr = 0x03000000; else if (argv[0][0] == '2' && !argv[0][1]) base_addr = 0x02000000; else { printf("ERROR: argument must be 1 or 2\n"); return; } printf("Base addr: %08X\n", base_addr); *(volatile u16 *)(base_addr + 0xAAA) = 0xAA; *(volatile u16 *)(base_addr + 0x554) = 0x55; *(volatile u16 *)(base_addr + 0xAAA) = 0x90; printf("offset 00: %04X\n", *(volatile u16 *)(base_addr + 0x00)); printf("offset 02: %04X\n", *(volatile u16 *)(base_addr + 0x02)); printf("offset 1C: %04X\n", *(volatile u16 *)(base_addr + 0x1C)); printf("offset 1E: %04X\n", *(volatile u16 *)(base_addr + 0x1E)); *(volatile u16 *)(base_addr + 0xAAA) = 0xF0; }