FreeCalypso > hg > freecalypso-tools
view target-utils/loadagent/cmdtab.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Thu, 31 Aug 2023 19:38:18 +0000 |
| parents | b34384991094 |
| children |
line wrap: on
line source
#include "cmdtab.h" extern void cmd_AMFB(); extern void cmd_AMFW(); extern void cmd_AMFWB(); extern void cmd_INFB(); extern void cmd_INFW(); extern void cmd_INFWB(); extern void cmd_abbr(); extern void cmd_abbw(); extern void cmd_blankchk(); extern void cmd_crc32(); extern void cmd_jump(); extern void cmd_r8(); extern void cmd_r16(); extern void cmd_r32(); extern void cmd_sertimeout(); extern void cmd_w8(); extern void cmd_w16(); extern void cmd_w32(); extern void cmd_baud_switch(); extern void cmd_binary_memload(); extern void cmd_intel_rewrite_sector(); extern void cmd_memdump_binary(); extern void cmd_memdump_human(); extern void cmd_memdump_machine(); extern void cmd_memload(); extern void abb_init(); extern void abb_power_off(); extern void abb_unlock_page2(); const struct cmdtab cmdtab[] = { {"AMFB", cmd_AMFB}, {"AMFW", cmd_AMFW}, {"AMFWB", cmd_AMFWB}, {"BINDUMP", cmd_memdump_binary}, {"BINML", cmd_binary_memload}, {"DUMP", cmd_memdump_machine}, {"INFB", cmd_INFB}, {"INFW", cmd_INFW}, {"INFWB", cmd_INFWB}, {"ML", cmd_memload}, {"abbinit", abb_init}, {"abbpage2", abb_unlock_page2}, {"abbr", cmd_abbr}, {"abbw", cmd_abbw}, {"baud", cmd_baud_switch}, {"blankchk", cmd_blankchk}, {"crc32", cmd_crc32}, {"dump", cmd_memdump_human}, {"intel-rewrite-sector", cmd_intel_rewrite_sector}, {"jump", cmd_jump}, {"poweroff", abb_power_off}, {"r8", cmd_r8}, {"r16", cmd_r16}, {"r32", cmd_r32}, {"sertimeout", cmd_sertimeout}, {"w8", cmd_w8}, {"w16", cmd_w16}, {"w32", cmd_w32}, {0, 0} };