FreeCalypso > hg > freecalypso-tools
view target-utils/libcommon/parseargs.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | e7502631a0f9 |
children |
line wrap: on
line source
/* * This module contains the parse_args() function, which parses the "rest" * part of an entered command into an argc/argv-style argument array. */ parse_args(unparsed, minargs, maxargs, argv, argcp) char *unparsed; int minargs, maxargs; char **argv; int *argcp; { int argc; char *cp; argc = 0; for (cp = unparsed; ; ) { while (*cp == ' ') cp++; if (!*cp) break; if (argc >= maxargs) { printf("ERROR: too many arguments\n"); return(-1); } argv[argc++] = cp; while (*cp && *cp != ' ') cp++; if (*cp) *cp++ = '\0'; } if (argc < minargs) { printf("ERROR: too few arguments\n"); return(-1); } argv[argc] = 0; if (argcp) *argcp = argc; return(0); }