FreeCalypso > hg > freecalypso-tools
view target-utils/libcommon/hexstrings.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | 0da2cf5a999c |
children |
line wrap: on
line source
/* * The decode_hex_digits() function contained in this module * will be used by the XRAM and flash loading commands * which take SREC-like long hex string arguments. */ #include <ctype.h> #include "types.h" decode_hex_digits(str, ndigits, valp) char *str; int ndigits; u32 *valp; { u32 accum; int i, c; accum = 0; for (i = 0; i < ndigits; i++) { c = *str++; if (!isxdigit(c)) return(-1); accum <<= 4; if (isdigit(c)) accum += c - '0'; else if (islower(c)) accum += c - 'a' + 10; else accum += c - 'A' + 10; } *valp = accum; return(0); }