view target-utils/libcommon/cmdentry.c @ 964:a96cb97b66a2

ringtools/imy: fix duplicate definition of tdma_durations[] The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>, although the present fix is slightly different from the contributed patch: because main.c doesn't need this tdma_durations[] array at all, let's simply remove the reference to this array from main.c rather than turn it into an extern. I no longer remember my original thought flow that resulted (by mistake) in tdma_durations[] being multiply defined in main.c and durations.c. My intent might have been to define all globals in main.c and have the reference in durations.c be an extern - and I missed that extern - but without clear memory, I have no certainty. In any case, having this data array defined in the same module that fills it (durations.c) is sensible, so let's make it the new way.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 31 Aug 2023 19:38:18 +0000
parents e7502631a0f9
children
line wrap: on
line source

/*
 * This module implements ASCII command entry via the serial port,
 * with normal echo and minimal editing (rubout and kill).
 *
 * The command string buffer is bss-allocated here as well.  It is
 * sized to allow a maximum-size S-record to be sent as a command,
 * as that is how we expect flash loading and XRAM chain-loading
 * to be done.
 */

#define	MAXCMD	527

char command[MAXCMD+1];

/*
 * The command_entry() function takes no arguments, and begins by waiting
 * for serial input - hence the prompt should be printed before calling it.
 *
 * This function returns when one of the following characters is received:
 * CR - accepts the command
 * ^C or ^U - cancels the command
 *
 * The return value is non-zero if a non-empty command was accepted with CR,
 * or 0 if the user hit CR with no input or if the command was canceled
 * with ^C or ^U.  In any case a CRLF is sent out the serial port
 * to close the input echo line before this function returns.
 */
command_entry()
{
	int inlen, ch;

	for (inlen = 0; ; ) {
		ch = mygetchar();
		if (ch >= ' ' && ch <= '~') {
			if (inlen < MAXCMD) {
				command[inlen++] = ch;
				putchar(ch);
			} else
				/* putchar(7) */;
			continue;
		}
		switch (ch) {
		case '\r':
		case '\n':
			command[inlen] = '\0';
			putchar('\n');
			return(inlen);
		case '\b':	/* BS */
		case 0x7F:	/* DEL */
			if (inlen) {
				putchar('\b');
				putchar(' ');
				putchar('\b');
				inlen--;
			} else
				/* putchar(7) */;
			continue;
		case 0x03:	/* ^C */
			putchar('^');
			putchar('C');
			putchar('\n');
			return(0);
		case 0x15:	/* ^U */
			putchar('^');
			putchar('U');
			putchar('\n');
			return(0);
		default:
			/* putchar(7) */;
		}
	}
}