view target-utils/libcommon/cmd_memdump_human.c @ 964:a96cb97b66a2

ringtools/imy: fix duplicate definition of tdma_durations[] The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>, although the present fix is slightly different from the contributed patch: because main.c doesn't need this tdma_durations[] array at all, let's simply remove the reference to this array from main.c rather than turn it into an extern. I no longer remember my original thought flow that resulted (by mistake) in tdma_durations[] being multiply defined in main.c and durations.c. My intent might have been to define all globals in main.c and have the reference in durations.c be an extern - and I missed that extern - but without clear memory, I have no certainty. In any case, having this data array defined in the same module that fills it (durations.c) is sensible, so let's make it the new way.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 31 Aug 2023 19:38:18 +0000
parents 9214118ae941
children
line wrap: on
line source

/*
 * This is a human-oriented memory dump command.  The dump is given in
 * both hex and ASCII, with readable spacing.
 */

#include <sys/types.h>
#include "types.h"

void
cmd_memdump_human(argbulk)
	char *argbulk;
{
	char *argv[3];
	u_long start, length;
	u_long offset;
	u_char intbuf[16];
	int i, c;

	if (parse_args(argbulk, 2, 2, argv, 0) < 0)
		return;
	if (parse_hexarg(argv[0], 8, &start) < 0) {
		printf("ERROR: arg1 must be a valid 32-bit hex address\n");
		return;
	}
	if (parse_hexarg(argv[1], 8, &length) < 0) {
	    printf("ERROR: arg2 must be a valid 32-bit hex value (length)\n");
		return;
	}
	if (start & 0xF || length & 0xF) {
	    printf("ERROR: implementation limit: 16-byte alignment required\n");
		return;
	}
	for (offset = 0; offset < length; offset += 0x10) {
		memcpy(intbuf, start + offset, 0x10);
		printf("%08X: ", start + offset);
		for (i = 0; i < 16; i++) {
			printf("%02X ", intbuf[i]);
			if ((i & 3) == 3)
				putchar(' ');
		}
		for (i = 0; i < 16; i++) {
			c = intbuf[i];
			if (c >= ' ' && c <= '~')
				putchar(c);
			else
				putchar('.');
		}
		putchar('\n');
	}
}