FreeCalypso > hg > freecalypso-tools
view target-utils/libcommon/abbcmd.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | 44a1de4264d8 |
children |
line wrap: on
line source
/* * abbr pg reg -- read ABB register * abbw pg reg val -- write ABB register */ #include <sys/types.h> #include "types.h" #include "abbdefs.h" extern u_long strtoul(); extern u16 abb_reg_read(); extern void abb_reg_write(); void cmd_abbr(argbulk) char *argbulk; { char *argv[3]; u32 pg, reg, val; if (parse_args(argbulk, 2, 2, argv, 0) < 0) return; pg = strtoul(argv[0], 0, 0); reg = strtoul(argv[1], 0, 0); if (pg > 2 || reg > 31) { printf("ERROR: argument(s) out of range\n"); return; } abb_init(); val = abb_reg_read(PAGE(pg) | reg); printf("%03X\n", val); } void cmd_abbw(argbulk) char *argbulk; { char *argv[4]; u32 pg, reg, val; if (parse_args(argbulk, 3, 3, argv, 0) < 0) return; pg = strtoul(argv[0], 0, 0); reg = strtoul(argv[1], 0, 0); val = strtoul(argv[2], 0, 16); if (pg > 2 || reg > 31 || val > 0x3FF) { printf("ERROR: argument(s) out of range\n"); return; } abb_init(); abb_reg_write(PAGE(pg) | reg, val); }