view target-utils/libbase/waitarm.S @ 964:a96cb97b66a2

ringtools/imy: fix duplicate definition of tdma_durations[] The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>, although the present fix is slightly different from the contributed patch: because main.c doesn't need this tdma_durations[] array at all, let's simply remove the reference to this array from main.c rather than turn it into an extern. I no longer remember my original thought flow that resulted (by mistake) in tdma_durations[] being multiply defined in main.c and durations.c. My intent might have been to define all globals in main.c and have the reference in durations.c be an extern - and I missed that extern - but without clear memory, I have no certainty. In any case, having this data array defined in the same module that fills it (durations.c) is sensible, so let's make it the new way.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 31 Aug 2023 19:38:18 +0000
parents 06ad5e30e8d0
children
line wrap: on
line source

/*
 * This assembly module provides a wait_ARM_cycles() function similar to
 * the one in TI's firmware; it is meant to gradually replace and phase out
 * osmo_delay_ms().  One loop count for this function equals 4 ARM clock
 * cycles when running out of IRAM; if the ARM clock is 52 MHz, 13 loop counts
 * equal one microsecond.
 *
 * Note the instruction sequence difference from TI's firmware version:
 * we use the SUBS instruction (equivalent of plain SUB in Thumb) and omit
 * the CMP, which is why our version is 4 cycles per loop (when running
 * out of IRAM), as opposed to 5 cycles per loop (plus wait states as they
 * execute from flash) in TI's fw version.
 */

	.text
	.code	32
	.globl	wait_ARM_cycles
wait_ARM_cycles:
	cmp	r0, #0
	bxeq	lr
1:	subs	r0, r0, #1
	bne	1b
	bx	lr