FreeCalypso > hg > freecalypso-tools
view target-utils/flash-boot-test/watchdog.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Thu, 31 Aug 2023 19:38:18 +0000 |
| parents | 3d7b546c710c |
| children |
line wrap: on
line source
#include <sys/types.h> #include "types.h" void cmd_wd() { /* stop/disable the watchdog timer */ *(volatile u16 *)0xFFFFF804 = 0xF5; *(volatile u16 *)0xFFFFF804 = 0xA0; } void cmd_we() { /* watchdog enable */ *(volatile u16 *)0xFFFFF804 = 0x8000; } void cmd_wr() { /* read and display watchdog downcount register */ printf("%04X\n", *(volatile u16 *)0xFFFFF802); } void cmd_ww(argbulk) char *argbulk; { /* single or double write to WATCHDOG_TIM_MODE */ char *argv[3]; u_long w1, w2; if (parse_args(argbulk, 1, 2, argv, 0) < 0) return; if (parse_hexarg(argv[0], 4, &w1) < 0) { printf("ERROR: arg1 must be a valid 16-bit hex value\n"); return; } if (argv[1] && parse_hexarg(argv[1], 4, &w2) < 0) { printf("ERROR: arg2 must be a valid 16-bit hex value\n"); return; } /* do it */ *(volatile u16 *)0xFFFFF804 = w1; if (argv[1]) *(volatile u16 *)0xFFFFF804 = w2; }
