view rvinterf/lowlevel/tchhide.c @ 964:a96cb97b66a2

ringtools/imy: fix duplicate definition of tdma_durations[] The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>, although the present fix is slightly different from the contributed patch: because main.c doesn't need this tdma_durations[] array at all, let's simply remove the reference to this array from main.c rather than turn it into an extern. I no longer remember my original thought flow that resulted (by mistake) in tdma_durations[] being multiply defined in main.c and durations.c. My intent might have been to define all globals in main.c and have the reference in durations.c be an extern - and I missed that extern - but without clear memory, I have no certainty. In any case, having this data array defined in the same module that fills it (durations.c) is sensible, so let's make it the new way.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 31 Aug 2023 19:38:18 +0000
parents a1065c17429c
children
line wrap: on
line source

/*
 * One of several FreeCalypso extensions to RVTMUX is TCH bit access
 * logical channel, and we would like to handle it specially in rvinterf
 * because it's extremely chatty, sending a frame every 20 ms.  If we
 * were to output every TCH frame in our regular log, that log output
 * becomes useless as everything else is drowned out.  Therefore, we
 * implement a hiding mode by default: we only count how many TCH packets
 * were exchanged in between other messages of interest, and report these
 * counts.
 */

#include <stdio.h>

extern void (*output_hook)();

unsigned tch_rx_count, tch_tx_count;

static void
tch_report_hook()
{
	char msgbuf[80];

	output_hook = 0;
	if (tch_rx_count) {
		sprintf(msgbuf, "TCH: received %u packet%s", tch_rx_count,
			tch_rx_count != 1 ? "s" : "");
		output_line(msgbuf);
		tch_rx_count = 0;
	}
	if (tch_tx_count) {
		sprintf(msgbuf, "TCH: sent %u packet%s", tch_tx_count,
			tch_tx_count != 1 ? "s" : "");
		output_line(msgbuf);
		tch_tx_count = 0;
	}
}

void
tch_inc_count_rx()
{
	tch_rx_count++;
	output_hook = tch_report_hook;
}

void
tch_inc_count_tx()
{
	tch_tx_count++;
	output_hook = tch_report_hook;
}