FreeCalypso > hg > freecalypso-tools
view rvinterf/asyncshell/sendarb.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | d43d82cbfb85 |
children |
line wrap: on
line source
/* * Command for sending arbitrary packets to the target */ #include <sys/types.h> #include <stdio.h> #include <ctype.h> #include <string.h> #include <strings.h> #include <stdlib.h> #include "limits.h" #include "exitcodes.h" cmd_send_common(argc, argv) char **argv; { u_char sendpkt[MAX_PKT_TO_TARGET]; unsigned pktlen = argc, i; char *endp; for (i = 0; i < pktlen; i++) { sendpkt[i] = strtoul(argv[i], &endp, 16); if (*endp) { printf( "error: all arguments to send command must be hex bytes\n"); return(ERROR_USAGE); } } /* send it! */ send_pkt_to_target(sendpkt, pktlen); return(0); } void cmd_send_interactive(argstr) char *argstr; { char *argv[MAX_PKT_TO_TARGET+1]; int argc, rc; rc = parse_interactive_command_into_argv(argstr, argv, 1, MAX_PKT_TO_TARGET, &argc); if (rc < 0) return; cmd_send_common(argc, argv); } cmd_send_oneshot(argc, argv) char **argv; { return cmd_send_common(argc - 1, argv + 1); }