FreeCalypso > hg > freecalypso-tools
view ringtools/Makefile @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Thu, 31 Aug 2023 19:38:18 +0000 |
| parents | b8ecdf54a957 |
| children |
line wrap: on
line source
CC= gcc CFLAGS= -O2 PROGS= fc-e1decode fc-e1gen fc-pwt-comp fc-ringlist-comp SCRIPTS=fc-imyplay fc-meltest-e1 fc-meltest-pwt SUBDIR= imy INSTALL_PREFIX= /opt/freecalypso INSTBIN=${INSTALL_PREFIX}/bin all: ${PROGS} ${SUBDIR} ${SUBDIR}: FRC cd $@; ${MAKE} ${MFLAGS} CC=${CC} CFLAGS="${CFLAGS}" fc-e1decode: fc-e1decode.c ${CC} ${CFLAGS} -o $@ $@.c fc-e1gen: fc-e1gen.c ${CC} ${CFLAGS} -o $@ $@.c fc-pwt-comp: fc-pwt-comp.c ${CC} ${CFLAGS} -o $@ $@.c fc-ringlist-comp: fc-ringlist-comp.c ${CC} ${CFLAGS} -o $@ $@.c install: mkdir -p ${INSTBIN} install -c ${PROGS} ${SCRIPTS} ${INSTBIN} for i in ${SUBDIR}; do (cd $$i; ${MAKE} ${MFLAGS} \ INSTALL_PREFIX=${INSTALL_PREFIX} install); done clean: rm -f ${PROGS} *.o *errs *.out for i in ${SUBDIR}; do (cd $$i; ${MAKE} ${MFLAGS} clean); done FRC:
