FreeCalypso > hg > freecalypso-tools
view loadtools/scripts/pirelli.init @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | e7502631a0f9 |
children |
line wrap: on
line source
# This phone has 3 memory chip selects: # # nCS0: flash chip select 1 # nCS1: RAM chip select # nCS3: flash chip select 2 # # All 3 chip select lines go to the same physical IC, a RAM/flash MCP. # We set WS=4 for all 3 here, copying what OsmocomBB does. The access # time listed in the datasheet is 70 ns for both RAM and flash, and per # my math setting WS=3 *might* work, but it could be marginal, so let's # play it safe for now. w16 fffffb00 00A4 w16 fffffb02 00A4 w16 fffffb06 00A4 # We also need to switch the CS4/ADD22 pin from its default function # of CS4 to the needed ADD22. w16 fffef006 0008 # With this phone all Calypso serial access always goes through the # CP2102 usb2serial IC inside the phone itself, which is programmed # to support the high non-standard baud rates. So we can safely # switch to 812500 baud unconditionally. baud 812500