FreeCalypso > hg > freecalypso-tools
view loadtools/old/CHANGES @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Thu, 31 Aug 2023 19:38:18 +0000 |
| parents | 62a91abc0300 |
| children |
line wrap: on
line source
Changes from loadtools-r2 to fc-host-tools-r3: * Implemented support for Mot C1xx (Compal) targets in addition to the previously supported Openmoko and Pirelli. Compal phones have different flash, require a different procedure for gaining code download access, and have additional bricking concerns. * Updated loadagent includes Intel flash support and ABB commands needed for Compal phones. * The range of IRAM addresses used by loadagent changed to allow gsm-fw ramImage builds (chain-loaded with fc-xram) to load their IRAM code section directly into place. * Loadtool's flash program-bin command now automatically performs a CRC-32 verification after programming. * Miscellaneous minor polish. Changes from loadtools-r1 to loadtools-r2: * A flash ID check has been implemented in fc-loadtool, invoked automatically before doing any erase or program operations, or explicitly at any time with the flash info command. This check ensures that the type of flash chip in the target GSM device is the same as what loadtool thinks it is, based on the hardware parameters file. * fc-xram command line syntax changed slightly in order to support immediate passing of the serial line to rvinterf/rvtdump. * Miscellaneous minor polish.