FreeCalypso > hg > freecalypso-tools
view libserial-linux/baudtab.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | fd7b447b99e3 |
children |
line wrap: on
line source
/* * This module contains the table of baud rates supported * by this implementation of FreeCalypso libserial. */ #include <stdio.h> #include <stdlib.h> #include <string.h> #include <strings.h> #include <asm/termbits.h> #include "baudrate.h" struct baudrate baud_rate_table[] = { /* the first listed rate will be our default */ {"115200", B115200, 0, 0, 100}, {"57600", B57600, 0, 1, 100}, {"38400", B38400, 0, 2, 100}, {"19200", B19200, 0, 4, 50}, /* Non-standard high baud rates */ {"812500", BOTHER, 812500, -1, 1000}, {"406250", BOTHER, 406250, -1, 500}, {"203125", BOTHER, 203125, -1, 250}, /* table search terminator */ {NULL, B0, 0, -1, 0}, }; struct baudrate * find_baudrate_by_name(srch_name) char *srch_name; { struct baudrate *br; for (br = baud_rate_table; br->name; br++) if (!strcmp(br->name, srch_name)) break; if (br->name) return(br); else { fprintf(stderr, "error: baud rate \"%s\" not known\n", srch_name); return(NULL); } }