FreeCalypso > hg > freecalypso-tools
view ffstools/caltools/fc-add-ramps.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | 5efb2832f4c2 |
children |
line wrap: on
line source
/* * This utility reads a tx-ramps table in FreeCalypso ASCII format, * sums up each ramp and reports these sums. The intended purpose is * to check if all ramps add up to 128 like they are supposed to. */ #include <sys/types.h> #include <stdio.h> #include <stdlib.h> #include <string.h> #include <strings.h> u_char data[512]; unsigned sums[32]; read_input(filename) char *filename; { char *format; if (read_rf_table_ext(filename, data, 1, &format, (unsigned *) 0)) exit(1); if (strcmp(format, "tx-ramps")) { fprintf(stderr, "error: %s is not a tx-ramps table\n", filename); exit(1); } } compute_sums() { int i, j; unsigned accum; u_char *dp = data; for (i = 0; i < 32; i++) { accum = 0; for (j = 0; j < 16; j++) accum += *dp++; sums[i] = accum; } } output() { unsigned n; for (n = 0; n < 16; n++) printf("Template #%u: ramp-up %u, ramp-down %u\n", n, sums[n*2], sums[n*2+1]); } main(argc, argv) char **argv; { if (argc != 2) { fprintf(stderr, "usage: %s tx-ramps-file\n", argv[0]); exit(1); } read_input(argv[1]); compute_sums(); output(); exit(0); }