view target-utils/Makefile @ 465:003e48f8ebe1

rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel I generally don't use NULL and use plain 0 instead, based on a "NULL considered harmful" discussion on the classiccmp mailing list many aeons ago (I couldn't find it, and I reason that it must have been 2005 or earlier), but a recent complaint by a packager sent me searching, and I found this: https://ewontfix.com/11/ While I don't give a @#$% about "modern" systems and code-nazi tools, I realized that passing a plain 0 as a pointer sentinel in execl is wrong because it will break on systems where pointers are longer than the plain int type. Again, I don't give a @#$% about the abomination of x86_64 and the like, but if anyone ever manages to port my code to something like a PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0 as a function argument where a pointer is expected most definitely won't work: if the most natural stack slot and SP alignment unit is 16 bits, fitting an int, with longs and pointers taking up two such slots, then the call stack will be totally wrong with a plain 0 passed for a pointer. Casting the 0 to (char *) ought to be the most kosher solution for the most retro systems possible.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 11 Feb 2019 00:00:19 +0000
parents 9b7ce2023355
children bbb4f92265d2
line wrap: on
line source

INSTPROGS=	buzplayer calversion compalstage c139explore flash-boot-wa \
		loadagent pirexplore simtest
ALLPROGS=	${INSTPROGS} c139-lldbg flash-boot-test helloapp tf-breakin
LIBS=		libbase libc libcommon libload libprintf libtiffs
SUBDIR=		${ALLPROGS} ${LIBS}

default:	${INSTPROGS}
all:		${ALLPROGS}

buzplayer:		libbase libc libcommon libprintf
c139explore:		libbase libc libcommon libprintf
c139-lldbg:		libbase libc libcommon libprintf
calversion:		libbase libc libcommon libprintf
flash-boot-test:	libbase libc libcommon libprintf
helloapp:		libbase libc libcommon libprintf
loadagent:		libbase libc libcommon libload libprintf
pirexplore:		libbase libc libcommon libprintf libtiffs
simtest:		libbase libc libcommon libprintf

${SUBDIR}: FRC
	cd $@; ${MAKE} ${MFLAGS}

install: FRC
	for i in ${INSTPROGS}; do (cd $$i; ${MAKE} ${MFLAGS} install); done

clean: FRC
	rm -f a.out core errs
	for i in ${SUBDIR}; do \
		if [ -d $$i ]; then \
			(cd $$i; ${MAKE} ${MFLAGS} clean) \
		fi \
	done

FRC: