view miscutil/fc-gsm2vm.c @ 465:003e48f8ebe1

rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel I generally don't use NULL and use plain 0 instead, based on a "NULL considered harmful" discussion on the classiccmp mailing list many aeons ago (I couldn't find it, and I reason that it must have been 2005 or earlier), but a recent complaint by a packager sent me searching, and I found this: https://ewontfix.com/11/ While I don't give a @#$% about "modern" systems and code-nazi tools, I realized that passing a plain 0 as a pointer sentinel in execl is wrong because it will break on systems where pointers are longer than the plain int type. Again, I don't give a @#$% about the abomination of x86_64 and the like, but if anyone ever manages to port my code to something like a PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0 as a function argument where a pointer is expected most definitely won't work: if the most natural stack slot and SP alignment unit is 16 bits, fitting an int, with longs and pointers taking up two such slots, then the call stack will be totally wrong with a plain 0 passed for a pointer. Casting the 0 to (char *) ought to be the most kosher solution for the most retro systems possible.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 11 Feb 2019 00:00:19 +0000
parents f736f3ce8310
children
line wrap: on
line source

/*
 * This utility converts a GSM 06.10 speech recording from the format that is
 * commonly accepted as standard in the Unix/Linux world (libgsm format) into
 * a voice memo file that can be uploaded into the FFS of a FreeCalypso device
 * and played with the audio_vm_play_start() API or the AT@VMP command that
 * invokes the latter.
 */

#include <sys/types.h>
#include <stdio.h>
#include <stdlib.h>

main(argc, argv)
	char **argv;
{
	FILE *inf, *outf;
	u_char libgsm_bytes[33], tidsp_bytes[34], arm_bytes[34];
	static u_char header_bytes[6] = {0x00, 0xC4, 0x00, 0x00, 0x00, 0x00};
	static u_char endmarker[2] = {0xFF, 0xFB};
	int cc, i, gotsome = 0;

	if (argc != 3) {
		fprintf(stderr, "usage: %s infile outfile\n", argv[0]);
		exit(1);
	}
	inf = fopen(argv[1], "r");
	if (!inf) {
		perror(argv[1]);
		exit(1);
	}
	outf = fopen(argv[2], "w");
	if (!outf) {
		perror(argv[2]);
		exit(1);
	}
	tidsp_bytes[33] = 0;
	for (;;) {
		cc = fread(libgsm_bytes, 1, 33, inf);
		if (cc < 33)
			break;
		if ((libgsm_bytes[0] & 0xF0) != 0xD0) {
invalid:		fprintf(stderr, "error: %s is not in libgsm format\n",
				argv[1]);
			exit(1);
		}
		gsm0610_libgsm_to_tidsp(libgsm_bytes, tidsp_bytes);
		for (i = 0; i < 34; i += 2) {
			arm_bytes[i] = tidsp_bytes[i+1];
			arm_bytes[i+1] = tidsp_bytes[i];
		}
		fwrite(header_bytes, 1, 6, outf);
		fwrite(arm_bytes, 1, 34, outf);
		gotsome = 1;
	}
	fwrite(endmarker, 1, 2, outf);
	fclose(outf);
	if (cc) {
		if (gotsome)
			fprintf(stderr,
			"warning: extra non-33 bytes at the end of %s\n",
				argv[1]);
		else
			goto invalid;
	}
	exit(0);
}