FreeCalypso > hg > freecalypso-tools
diff rvinterf/etmsync/fsread.c @ 921:74d284add54d
fc-fsio: guard against bogus readdir results from the target
If the FFS being operated on contains SE K2x0 extended filenames,
readdir will return strings that are bad for printing. We need to
guard against this possibility, and also against possible other
bogosity that could be sent by other alien firmwares.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sat, 31 Dec 2022 22:55:23 +0000 |
| parents | d332fbf5c145 |
| children |
line wrap: on
line diff
--- a/rvinterf/etmsync/fsread.c Sat Dec 31 21:08:05 2022 +0000 +++ b/rvinterf/etmsync/fsread.c Sat Dec 31 22:55:23 2022 +0000 @@ -50,6 +50,20 @@ } } +ls_is_sane(name) + char *name; +{ + char *cp; + int c; + + cp = name; + while (c = *cp++) { + if (c < '!' || c > '~') + return(0); + } + return(1); +} + do_ls_long(lsarg) char *lsarg; { @@ -87,6 +101,10 @@ printf("error: readdir result contains a slash\n"); return(ERROR_TARGET); } + if (!ls_is_sane(rdbuf)) { + printf("error: readdir result contains non-printable chars\n"); + return(ERROR_TARGET); + } strcpy(childp, rdbuf); rc = do_xlstat(childpath, &stat); if (rc) { @@ -235,6 +253,10 @@ printf("error: readdir result contains a slash\n"); return(ERROR_TARGET); } + if (!ls_is_sane(rdbuf)) { + printf("error: readdir result contains non-printable chars\n"); + return(ERROR_TARGET); + } strcpy(childp, rdbuf); if (rdbuf[0] == '.') { printf("skipping %s\n", ffspath_child);