FreeCalypso > hg > freecalypso-tools
annotate rvinterf/include/exitcodes.h @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Thu, 31 Aug 2023 19:38:18 +0000 |
| parents | 0bf06b68ac95 |
| children |
| rev | line source |
|---|---|
|
0
e7502631a0f9
initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
1 #define ERROR_USAGE 1 |
|
e7502631a0f9
initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
2 #define ERROR_TARGET 2 |
|
e7502631a0f9
initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
3 #define ERROR_RVINTERF 3 |
|
e7502631a0f9
initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
4 #define ERROR_UNIX 4 |
|
e7502631a0f9
initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
5 #define ERROR_BUG 5 |
|
237
0bf06b68ac95
rvinterf/include/exitcodes.h: added ERROR_RFFAIL for fc-rfcal-tools
Mychaela Falconia <falcon@freecalypso.org>
parents:
220
diff
changeset
|
6 /* the following two are for fc-rfcal-tools */ |
|
0bf06b68ac95
rvinterf/include/exitcodes.h: added ERROR_RFFAIL for fc-rfcal-tools
Mychaela Falconia <falcon@freecalypso.org>
parents:
220
diff
changeset
|
7 #define ERROR_RFTEST 6 /* error in the external RF test equipment */ |
|
0bf06b68ac95
rvinterf/include/exitcodes.h: added ERROR_RFFAIL for fc-rfcal-tools
Mychaela Falconia <falcon@freecalypso.org>
parents:
220
diff
changeset
|
8 #define ERROR_RFFAIL 7 /* RF calibration process failure */ |
