FreeCalypso > hg > freecalypso-tools
annotate ringtools/e1-experiments/test4.src @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Thu, 31 Aug 2023 19:38:18 +0000 |
| parents | 17523db6d1dc |
| children |
| rev | line source |
|---|---|
|
174
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
1 osc-set 0 |
|
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
2 |
|
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
3 time 1 |
|
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
4 osc 0 63 32 300 |
|
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
5 |
|
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
6 time 250 |
|
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
7 |
|
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
8 time 250 |
|
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
9 |
|
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
10 time 250 |
|
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
11 |
|
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
12 time 250 |
|
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
13 |
|
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
14 time 250 |
|
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
15 |
|
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
16 time 250 |
|
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
17 |
|
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
18 time 250 |
|
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
19 |
|
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
20 time 250 |
|
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
21 |
|
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
22 time 250 |
|
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
23 |
|
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
24 time 250 |
|
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
25 |
|
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
26 time 250 |
|
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
27 |
|
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
28 time 250 |
|
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
29 osc 0 63 32 300 |
|
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
30 |
|
17523db6d1dc
e1-experiments: checking in test4.src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
31 end |
