FreeCalypso > hg > freecalypso-tools
annotate target-utils/pln-ppb-test/read_id.c @ 1011:6d9b10633f10
etmsync Pirelli IMEI retrieval: fix poor use of printf()
Bug reported by Vadim Yanitskiy <fixeria@osmocom.org>: the construct
where a static-allocated string was passed to printf() without any
format arguments causes newer compilers to report a security problem.
Given that formatted output is not needed here, just fixed string
output, change printf() to fputs(), and direct the error message
to stderr while at it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Thu, 23 May 2024 17:29:57 +0000 |
| parents | 5a6019ed7e72 |
| children |
| rev | line source |
|---|---|
|
988
5a6019ed7e72
pln-ppb-test: implement read-id
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
1 /* |
|
5a6019ed7e72
pln-ppb-test: implement read-id
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
2 * read-id (Autoselect) command |
|
5a6019ed7e72
pln-ppb-test: implement read-id
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
3 */ |
|
5a6019ed7e72
pln-ppb-test: implement read-id
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
4 |
|
5a6019ed7e72
pln-ppb-test: implement read-id
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
5 #include <sys/types.h> |
|
5a6019ed7e72
pln-ppb-test: implement read-id
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
6 #include "types.h" |
|
5a6019ed7e72
pln-ppb-test: implement read-id
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
7 |
|
5a6019ed7e72
pln-ppb-test: implement read-id
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
8 void |
|
5a6019ed7e72
pln-ppb-test: implement read-id
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
9 cmd_read_id(argbulk) |
|
5a6019ed7e72
pln-ppb-test: implement read-id
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
10 char *argbulk; |
|
5a6019ed7e72
pln-ppb-test: implement read-id
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
11 { |
|
5a6019ed7e72
pln-ppb-test: implement read-id
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
12 char *argv[2]; |
|
5a6019ed7e72
pln-ppb-test: implement read-id
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
13 u_long addr; |
|
5a6019ed7e72
pln-ppb-test: implement read-id
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
14 |
|
5a6019ed7e72
pln-ppb-test: implement read-id
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
15 if (parse_args(argbulk, 1, 1, argv, 0) < 0) |
|
5a6019ed7e72
pln-ppb-test: implement read-id
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
16 return; |
|
5a6019ed7e72
pln-ppb-test: implement read-id
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
17 if (parse_hexarg(argv[0], 8, &addr) < 0) { |
|
5a6019ed7e72
pln-ppb-test: implement read-id
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
18 printf("ERROR: argument must be a valid 32-bit hex address\n"); |
|
5a6019ed7e72
pln-ppb-test: implement read-id
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
19 return; |
|
5a6019ed7e72
pln-ppb-test: implement read-id
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
20 } |
|
5a6019ed7e72
pln-ppb-test: implement read-id
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
21 if (addr & 0xFFFF) { |
|
5a6019ed7e72
pln-ppb-test: implement read-id
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
22 printf("ERROR: address is not on 64 KiB boundary\n"); |
|
5a6019ed7e72
pln-ppb-test: implement read-id
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
23 return; |
|
5a6019ed7e72
pln-ppb-test: implement read-id
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
24 } |
|
5a6019ed7e72
pln-ppb-test: implement read-id
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
25 *(volatile u16 *)(addr + 0xAAA) = 0xAA; |
|
5a6019ed7e72
pln-ppb-test: implement read-id
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
26 *(volatile u16 *)(addr + 0x554) = 0x55; |
|
5a6019ed7e72
pln-ppb-test: implement read-id
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
27 *(volatile u16 *)(addr + 0xAAA) = 0x90; |
|
5a6019ed7e72
pln-ppb-test: implement read-id
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
28 } |
