annotate target-utils/flash-boot-test/cmdtab.c @ 465:003e48f8ebe1

rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel I generally don't use NULL and use plain 0 instead, based on a "NULL considered harmful" discussion on the classiccmp mailing list many aeons ago (I couldn't find it, and I reason that it must have been 2005 or earlier), but a recent complaint by a packager sent me searching, and I found this: https://ewontfix.com/11/ While I don't give a @#$% about "modern" systems and code-nazi tools, I realized that passing a plain 0 as a pointer sentinel in execl is wrong because it will break on systems where pointers are longer than the plain int type. Again, I don't give a @#$% about the abomination of x86_64 and the like, but if anyone ever manages to port my code to something like a PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0 as a function argument where a pointer is expected most definitely won't work: if the most natural stack slot and SP alignment unit is 16 bits, fitting an int, with longs and pointers taking up two such slots, then the call stack will be totally wrong with a plain 0 passed for a pointer. Casting the 0 to (char *) ought to be the most kosher solution for the most retro systems possible.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 11 Feb 2019 00:00:19 +0000
parents dbb54db721d1
children cd900b885eb2
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
197
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 #include "cmdtab.h"
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 extern void cmd_abbr();
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 extern void cmd_abbw();
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 extern void cmd_jump();
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 extern void cmd_r8();
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 extern void cmd_r16();
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 extern void cmd_r32();
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 extern void cmd_w8();
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 extern void cmd_w16();
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 extern void cmd_w32();
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 extern void cmd_memdump_human();
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 extern void abb_init();
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 extern void abb_power_off();
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 const struct cmdtab cmdtab[] = {
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 {"abbinit", abb_init},
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 {"abbr", cmd_abbr},
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 {"abbw", cmd_abbw},
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 {"dump", cmd_memdump_human},
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 {"jump", cmd_jump},
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 {"poweroff", abb_power_off},
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 {"r8", cmd_r8},
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 {"r16", cmd_r16},
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 {"r32", cmd_r32},
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 {"w8", cmd_w8},
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 {"w16", cmd_w16},
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 {"w32", cmd_w32},
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 {0, 0}
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 };