annotate target-utils/flash-boot-test/Makefile @ 465:003e48f8ebe1

rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel I generally don't use NULL and use plain 0 instead, based on a "NULL considered harmful" discussion on the classiccmp mailing list many aeons ago (I couldn't find it, and I reason that it must have been 2005 or earlier), but a recent complaint by a packager sent me searching, and I found this: https://ewontfix.com/11/ While I don't give a @#$% about "modern" systems and code-nazi tools, I realized that passing a plain 0 as a pointer sentinel in execl is wrong because it will break on systems where pointers are longer than the plain int type. Again, I don't give a @#$% about the abomination of x86_64 and the like, but if anyone ever manages to port my code to something like a PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0 as a function argument where a pointer is expected most definitely won't work: if the most natural stack slot and SP alignment unit is 16 bits, fitting an int, with longs and pointers taking up two such slots, then the call stack will be totally wrong with a plain 0 passed for a pointer. Casting the 0 to (char *) ought to be the most kosher solution for the most retro systems possible.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 11 Feb 2019 00:00:19 +0000
parents cc6594a7fc7a
children 58d3a0634272
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
197
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 CC= arm-elf-gcc
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 CFLAGS= -Os -fno-builtin
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CPPFLAGS=-I../include
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 LD= arm-elf-ld
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 OBJCOPY=arm-elf-objcopy
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
200
cc6594a7fc7a target-utils/flash-boot-test: added UART init, needed for mode 1
Mychaela Falconia <falcon@freecalypso.org>
parents: 197
diff changeset
7 OBJS= vectors.o crt0.o cmdtab.o main.o mygetchar.o uartbase.o uartinit.o
197
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 LIBS= ../libcommon/libcommon.a ../libprintf/libprintf.a ../libbase/libbase.a \
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 ../libc/libc.a
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 LIBGCC= `${CC} -print-file-name=libgcc.a`
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 LDS= ld.script
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 all: fbt-mode0.bin fbt-mode1.bin
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 crt0.S: ../env/crt0.S
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 ln -s $< .
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 fbt-mode0.elf: ${OBJS} magic0.o ${LIBS} ${LDS}
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 ${LD} -N -T ${LDS} -o $@ ${OBJS} magic0.o ${LIBS} ${LIBGCC}
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 fbt-mode0.bin: fbt-mode0.elf
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 ${OBJCOPY} -O binary $< $@
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 fbt-mode1.elf: ${OBJS} magic1.o ${LIBS} ${LDS}
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 ${LD} -N -T ${LDS} -o $@ ${OBJS} magic1.o ${LIBS} ${LIBGCC}
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 fbt-mode1.bin: fbt-mode1.elf
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 ${OBJCOPY} -O binary $< $@
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 clean:
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 rm -f *.o *errs *core *.elf *.bin *.srec crt0.S
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32
dbb54db721d1 target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 FRC: