FreeCalypso > hg > fc-tourmaline
changeset 303:f76436d19a7a default tip
!GPRS config: fix long-standing AT+COPS chance hanging bug
There has been a long-standing bug in FreeCalypso going back years:
sometimes in the AT command bring-up sequence of an ACI-only MS,
the AT+COPS command would produce only a power scan followed by
cessation of protocol stack activity (only L1 ADC traces), instead
of the expected network search sequence. This behaviour was seen
in different FC firmware versions going back to Citrine, and seemed
to follow some law of chance, not reliably repeatable.
This bug has been tracked down and found to be specific to !GPRS
configuration, stemming from our TCS2/TCS3 hybrid and reconstruction
of !GPRS support that was bitrotten in TCS3.2/LoCosto version.
ACI module psa_mms.c, needed only for !GPRS, was missing in the TCS3
version and had to be pulled from TCS2 - but as it turns out,
there is a new field in the MMR_REG_REQ primitive that needs to be
set correctly, and that psa_mms.c module is the place where this
initialization needed to be added.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 08 Jun 2023 08:23:37 +0000 |
parents | d32ac4edb634 |
children | |
files | src/g23m-aci/aci/psa_mms.c |
diffstat | 1 files changed, 10 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/src/g23m-aci/aci/psa_mms.c Mon Jun 05 21:34:33 2023 +0000 +++ b/src/g23m-aci/aci/psa_mms.c Thu Jun 08 08:23:37 2023 +0000 @@ -113,7 +113,15 @@ mmr_reg_req->service_mode = SERVICE_MODE_FULL; } - + /* + * FreeCalypso TCS2/TCS3 hybrid: this C module was taken from TCS211, + * but the new TCS3 version of mmreg SAP has a new field in MMR_REG_REQ + * primitive that needs to be set. The new field is bootup_act, it needs + * to be set to NORMAL_REG for classic TCS2-like operation of this SAP, + * and failure to set it results in uninitialized memory garbage being + * passed to MM, producing law-of-chance Heisenbug behaviour. + */ + mmr_reg_req->bootup_act = NORMAL_REG; PSENDX (MM, mmr_reg_req); } @@ -195,6 +203,7 @@ { PALLOC (mmr_reg_req, MMR_REG_REQ); mmr_reg_req->service_mode = SERVICE_MODE_FULL; + mmr_reg_req->bootup_act = NORMAL_REG; PSENDX (MM, mmr_reg_req); frstFlg = FALSE; }