FreeCalypso > hg > fc-tourmaline
view src/cs/drivers/drv_app/spi/spi_process.c @ 268:f2e52cab0a73
abb_inth.c: check all interrupt causes, not just one
The original code used if - else if - else if etc constructs, thus
the first detected interrupt was the only one handled. However,
Iota ITSTATREG is a clear-on-read register, thus if we only handle
the first detected interrupt and skip checking the others, then the
other interrupts will be lost, if more than one interrupt happened
to occur in one ABB interrupt handling cycle - a form of rare race
condition. Change the code to check all interrupts that were read
in this cycle.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 13 Jun 2021 18:17:53 +0000 |
parents | 34b7059b9337 |
children |
line wrap: on
line source
/*****************************************************************************/ /* */ /* Name spi_process.c */ /* */ /* Function this file contains the spi_process function, used to */ /* handle messages received in the SPI mailbox, and used to */ /* access the ABB. It is called by the spi task core. */ /* */ /* Version 0.1 */ /* */ /* Date Modification */ /* ------------------------------------ */ /* 20/08/2000 Create */ /* */ /* Author */ /* */ /* (C) Copyright 2000 by Texas Instruments Incorporated, All Rights Reserved */ /*****************************************************************************/ #include "rvf/rvf_api.h" #include "spi/spi_api.h" #include "rvm/rvm_use_id_list.h" #include "spi/spi_process.h" #include "rv/rv_defined_swe.h" // for RVM_PWR_SWE /******************************************************************************* ** Function spi_process ** *******************************************************************************/ UINT8 spi_process(T_RV_HDR * msg_ptr) { UINT16 data ; if(msg_ptr != NULL) { switch (msg_ptr->msg_id) { case ABB_EXT_IRQ_EVT: { /* Call to the low-level driver function : interrupt status register reading */ data = ABB_Read_Register_on_page(PAGE0, ITSTATREG); /* Callback function */ if(msg_ptr->callback_func != NULL) { msg_ptr->callback_func(&data); } rvf_free_buf ((void *) msg_ptr); break; } case SPI_ABB_READ_EVT: { rvf_send_trace("SPI_task: SPI_READ_ABB_EVT received", 35, NULL_PARAM, RV_TRACE_LEVEL_DEBUG_LOW, SPI_USE_ID); /* Call to the low-level driver function */ data = ABB_Read_Register_on_page(((T_SPI_READ *)msg_ptr)->page, ((T_SPI_READ *)msg_ptr)->address); /* Callback function */ if(((T_SPI_READ *)msg_ptr)->os_hdr.callback_func != NULL) { ((T_SPI_READ *)msg_ptr)->os_hdr.callback_func(&data); } rvf_free_buf ((void *) msg_ptr); return 0; } case SPI_ABB_WRITE_EVT: { rvf_send_trace("SPI_task: SPI_WRITE_ABB_EVT received", 36, NULL_PARAM, RV_TRACE_LEVEL_DEBUG_LOW, SPI_USE_ID); /* Call to the low-level driver function */ ABB_Write_Register_on_page(((T_SPI_WRITE *)msg_ptr)->page, ((T_SPI_WRITE *)msg_ptr)->address, ((T_SPI_WRITE *)msg_ptr)->data); rvf_free_buf ((void *) msg_ptr); return 0; } case SPI_ABB_CONF_ADC_EVT: { rvf_send_trace("SPI_task: SPI_ABB_CONF_ADC_EVT received", 39, NULL_PARAM, RV_TRACE_LEVEL_DEBUG_LOW, SPI_USE_ID); /* Call to the low-level driver function */ ABB_Conf_ADC(((T_SPI_ABB_CONF_ADC *)msg_ptr)->channels, ((T_SPI_ABB_CONF_ADC *)msg_ptr)->itval); rvf_free_buf ((void *) msg_ptr); return 0; } case SPI_ABB_READ_ADC_EVT: { rvf_send_trace("SPI_task: SPI_ABB_READ_ADC_EVT received", 39, NULL_PARAM, RV_TRACE_LEVEL_DEBUG_LOW, SPI_USE_ID); /* Call to the low-level driver function */ ABB_Read_ADC(((T_SPI_ABB_READ_ADC *)msg_ptr)->Buff); /* Callback function */ if(((T_SPI_ABB_READ_ADC *)msg_ptr)->callback_func != NULL) { ((T_SPI_ABB_READ_ADC *)msg_ptr)->callback_func(); } rvf_free_buf ((void *) msg_ptr); return 0; } default: { /* Unknown message has been received */ #ifdef RVM_PWR_SWE rvf_send_trace("SPI_task : Received an unknown or a PWR message",47, NULL_PARAM , RV_TRACE_LEVEL_DEBUG_HIGH, SPI_USE_ID); #else rvf_send_trace("SPI_task : Received an unknown message",38, NULL_PARAM , RV_TRACE_LEVEL_DEBUG_HIGH, SPI_USE_ID); rvf_free_buf ((void *) msg_ptr); #endif return 1; } } // end of switch } // end of if (msg_ptr != NULL) return 0; }