FreeCalypso > hg > fc-tourmaline
view src/ui/bmi/mmiUserData.h @ 78:c632896652ba
mfw/ti1_key.c: properly initialize notified_keys array
The code in this ti1_key.c layer needs to call kpd_subscribe() and
kpd_define_key_notification() functions in order to register with the
KPD driver. The original code passed KPD_NB_PHYSICAL_KEYS in
nb_notified_keys - this constant is defined to 24 in kpd_cfg.h on all
platforms of interest to us - but it only filled the first 23 slots
in the notified_keys array, resulting in stack garbage being passed
to KPD API functions. The fix consists of initializing the last
missed array slot to KPD_KEY_RECORD, the key ID for the right side
button on the D-Sample handset.
On our current hw targets this "Record" button exists as the EXTRA
button on our Luna keypad board and as the camera button on the
Pirelli DP-L10. There is no support whatsoever for this button
in current BMI+MFW, we have no plans of doing anything with Pirelli's
camera button even if we do get our UI fw running on that phone,
and the Mother's dream of building our own FreeCalypso handset with
the same button arrangement as D-Sample (including the right side
button) is currently very nebulous - but let us nonetheless handle
the full set of buttons on the KPD to MFW interface, and let upper
layers weed out unsupported buttons.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 25 Oct 2020 23:41:01 +0000 |
| parents | 67bfe9f274f6 |
| children | c0052fe355d3 |
line wrap: on
line source
#ifndef _DEF_MMI_USERDATA_H_ #define _DEF_MMI_USERDATA_H_ /******************************************************************************* CONDAT (UK) ******************************************************************************** This software product is the property of Condat (UK) Ltd and may not be disclosed to any third party without the express permission of the owner. ******************************************************************************** $Project name: Basic MMI $Project code: BMI (6349) $Module: MMI $File: MmiUserData.h $Revision: 1.0 $Author: Condat(UK) $Date: 25/10/00 ******************************************************************************** Description: This provides the root mofule for the basic MMI ******************************************************************************** $History: MmiUserData.h $End *******************************************************************************/ #define ALLOC_MEMORY mfwAlloc #define FREE_MEMORY mfwFree /* * The following enum is the _only_ place where keys for the userData mechanism * can be defined. Everybody _can_ and _must_ define their own keys for * _every_ particular use of userData. */ typedef enum { UD_SOFTKEYS, UD_OLD_FOCUS, UD_SAT_BITS, UD_SAT_HANDLE, UD_SAT_KEYBOARD, UD_SAT_MENU, UD_SAT_MENU_ATTRIBUTES, UD_SAT_MENU_IDS, UD_SAT_MENU_STRINGPOOL, UD_SAT_SETUPMENU_COMMAND, UD_KBD, UD_PARENTWIN, UD_MENU } UserKey; /* * Please note that all functions below come in a userDataHnd... and userDataWin... * version, which have identical functionality, but get the <window> passed * in MfwHnd or MfwWin pointer form respectively. * You can just use either one depending on what you got hold of at the moment. */ void *userDataHndSet( MfwHnd window, UserKey key, void *data); void *userDataWinSet( MfwWin *window, UserKey key, void *data); /* * Sets the user data for <window> with <key> to <data>, * and returns the previous contents of the user data. * If <data> itself is returned no user data with <key> * existed and a new user data element with <key> has been created * and set to <data>. * If NULL is returned, either <window> was invalid or a new user data * element could not be created. */ void *userDataHndGet( MfwHnd window, UserKey key); void *userDataWinGet( MfwWin *window, UserKey key); /* * Returns the user data for <window> with <key>. * If NULL is returned, either <window> was invalid or no user data * with <key> existed. */ void *userDataHndDelete( MfwHnd window, UserKey key); void *userDataWinDelete( MfwWin *window, UserKey key); /* * Deletes the user data for <window> with <key>, and returns the * contents of the user data. * If NULL is returned, either <window> was invalid or no user data * with <key> existed. */ #endif
