FreeCalypso > hg > fc-tourmaline
view src/cs/riviera/rvt/rvt_def_i.h @ 78:c632896652ba
mfw/ti1_key.c: properly initialize notified_keys array
The code in this ti1_key.c layer needs to call kpd_subscribe() and
kpd_define_key_notification() functions in order to register with the
KPD driver. The original code passed KPD_NB_PHYSICAL_KEYS in
nb_notified_keys - this constant is defined to 24 in kpd_cfg.h on all
platforms of interest to us - but it only filled the first 23 slots
in the notified_keys array, resulting in stack garbage being passed
to KPD API functions. The fix consists of initializing the last
missed array slot to KPD_KEY_RECORD, the key ID for the right side
button on the D-Sample handset.
On our current hw targets this "Record" button exists as the EXTRA
button on our Luna keypad board and as the camera button on the
Pirelli DP-L10. There is no support whatsoever for this button
in current BMI+MFW, we have no plans of doing anything with Pirelli's
camera button even if we do get our UI fw running on that phone,
and the Mother's dream of building our own FreeCalypso handset with
the same button arrangement as D-Sample (including the right side
button) is currently very nebulous - but let us nonetheless handle
the full set of buttons on the KPD to MFW interface, and let upper
layers weed out unsupported buttons.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 25 Oct 2020 23:41:01 +0000 |
parents | 4e78acac3d88 |
children |
line wrap: on
line source
/******************************************************************************* * * rvt_def_i.h * * (C) Texas Instruments, all rights reserved * * Version number : 0.1 * * History : 0.1 (7/5/2000) - Created * * Date : 7/5/2000 * * Author : Guido Pagana g-pagana@ti.com * ******************************************************************************/ #ifndef __RVT_DEF_I_H__ #define __RVT_DEF_I_H__ #include "rvt/rvt_gen.h" #include "rvt/rvt_pool_size.h" /* Stack & Memory Bank sizes definitions */ /************************* Internal definitions **************************/ /* Define the maximum number of msg lost before sending an alert */ #define RVT_MAX_LOST_TRACE_MSG (1) /* Trace user database (must end using RVT_END_OF_TABLE) */ #define RVT_END_OF_TABLE {"", RVT_INVALID_HEADER, NULL} #define RVT_USER_ID_MAPPING { \ {"RV", RVT_RV_HEADER, NULL}, \ {"L1", RVT_L1_HEADER, NULL}, \ {"L23", RVT_L23_HEADER, NULL}, \ {"TM", RVT_TM_HEADER, NULL}, \ {"RNET", RVT_RNET_HEADER, NULL}, \ {"PROF", RVT_PROF_HEADER, NULL}, \ {"GTTBACK", RVT_GTTBACK_HEADER, NULL}, \ {"OTHER", RVT_OTHER_HEADER, NULL}, \ {"AT", RVT_AT_HEADER, NULL}, \ {"EXTUI", RVT_EXTUI_HEADER, NULL}, \ {"TCH", RVT_TCH_HEADER, NULL}, \ {"KEEPALIVE", RVT_KEEPALIVE_HEADER, NULL}, \ RVT_END_OF_TABLE \ } /* Trace task mailbox */ #define RVT_TRACE_MAILBOX RVF_TASK_MBOX_0 typedef struct { T_RVT_NAME user_name[RVT_NAME_MAX_LEN]; T_RVT_USER_ID user_id; RVT_CALLBACK_FUNC rx_callback_func; } T_RVT_USER_DB; /* Define the unique message type used in RVT */ #define RVT_TRACE_RQST_ID ( (RVT_USE_ID & 0xFFFF0000) | ( 0x1) | 0x001) typedef struct { T_RV_HDR header; T_RVT_USER_ID user_id; T_RVT_FORMAT format; T_RVT_MSG_LG msg_length; } T_RVT_TRACE_RQST; /* Trace message header size */ #define RVT_HEADER_SIZE (sizeof(T_RVT_TRACE_RQST) ) #define TRACE_TASK_STACK_SIZE TRACE_STACK_SIZE #define TRACE_MB_SIZE (TRACE_MB1_SIZE) #define TRACE_MB_WATERMARK (TRACE_MB_SIZE) /* Decimal to hexadecimal conversion table */ static const char Num2Char[] = {'0','1','2','3','4','5','6','7','8','9','A','B','C','D','E','F'}; /* ** Number of messages lost. Causes: ** ** __ 'Format' differs from RVT_ASCII_FORMAT and RVT_BINARY_FORMAT. ** | __ 'Message ID' differs from RVT_TRACE_RQST_ID. ** | | __ rvf_read_mbox has returned NULL. ** | | | __ Failed to send the message. ** | | | | __ Insufficient resources. ** | | | | | __ Trace Module not started. ** |_|_|_|_|_|____________________________________________________ ** | ¦ ¦ ¦ ¦ ¦ ¦ | | | | ** | ¦ ¦ ¦ ¦ ¦ ¦ | | | | ** |_¦_¦_¦_¦_¦_¦_._|_._._._._._._._|_._._._._._._._|_._._._._._._._| */ typedef union { struct { INT32 count : 26; INT32 not_started : 1; INT32 insufficient_resources : 1; INT32 message_not_sent : 1; INT32 message_empty : 1; INT32 unknown_request : 1; INT32 unknown_format : 1; } bit_mask; UINT32 overall_value; } T_RVT_LOST_MSG; extern T_RVT_LOST_MSG rvt_lost_msg_cpt; /* Prototypes */ BOOLEAN rvt_name_cmp( char * str1, char * str2); void rvt_activate_RX_HISR (void); void rvt_RX_process (void); #endif /* __RVT_DEF_I_H__ */