view src/cs/layer1/dsp1/patch_file36_10.c @ 78:c632896652ba

mfw/ti1_key.c: properly initialize notified_keys array The code in this ti1_key.c layer needs to call kpd_subscribe() and kpd_define_key_notification() functions in order to register with the KPD driver. The original code passed KPD_NB_PHYSICAL_KEYS in nb_notified_keys - this constant is defined to 24 in kpd_cfg.h on all platforms of interest to us - but it only filled the first 23 slots in the notified_keys array, resulting in stack garbage being passed to KPD API functions. The fix consists of initializing the last missed array slot to KPD_KEY_RECORD, the key ID for the right side button on the D-Sample handset. On our current hw targets this "Record" button exists as the EXTRA button on our Luna keypad board and as the camera button on the Pirelli DP-L10. There is no support whatsoever for this button in current BMI+MFW, we have no plans of doing anything with Pirelli's camera button even if we do get our UI fw running on that phone, and the Mother's dream of building our own FreeCalypso handset with the same button arrangement as D-Sample (including the right side button) is currently very nebulous - but let us nonetheless handle the full set of buttons on the KPD to MFW interface, and let upper layers weed out unsupported buttons.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 25 Oct 2020 23:41:01 +0000
parents 4e78acac3d88
children
line wrap: on
line source

/*
 * The only DSP patch code we have for 36_10 is the dynamic download version
 * which we have extracted from the world's last surviving copy of TCS211 fw
 * for Calypso modems.  The purpose of this cheesy patch_file36_10.c wrapper
 * is to allow experimental builds with L1_DYN_DSP_DWNLD=0: we use the static
 * portion of our only available patch code, and simply not do the dynamic part.
 *
 * This configuration is intended only for experiments, not for production!
 * The dynamic parts of the DSP patch code which this configuration omits
 * are surely there for some good reason, and we can only guess what we are
 * going to destabilize by disabling them.
 */

#include "patch_file36_10_dyn_dwl.c"