view cdg-hybrid/fflags.h @ 78:c632896652ba

mfw/ti1_key.c: properly initialize notified_keys array The code in this ti1_key.c layer needs to call kpd_subscribe() and kpd_define_key_notification() functions in order to register with the KPD driver. The original code passed KPD_NB_PHYSICAL_KEYS in nb_notified_keys - this constant is defined to 24 in kpd_cfg.h on all platforms of interest to us - but it only filled the first 23 slots in the notified_keys array, resulting in stack garbage being passed to KPD API functions. The fix consists of initializing the last missed array slot to KPD_KEY_RECORD, the key ID for the right side button on the D-Sample handset. On our current hw targets this "Record" button exists as the EXTRA button on our Luna keypad board and as the camera button on the Pirelli DP-L10. There is no support whatsoever for this button in current BMI+MFW, we have no plans of doing anything with Pirelli's camera button even if we do get our UI fw running on that phone, and the Mother's dream of building our own FreeCalypso handset with the same button arrangement as D-Sample (including the right side button) is currently very nebulous - but let us nonetheless handle the full set of buttons on the KPD to MFW interface, and let upper layers weed out unsupported buttons.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 25 Oct 2020 23:41:01 +0000
parents 35f7a1dc9f7d
children
line wrap: on
line source

/*
 * This version of fflags.h (ccdgen config file) is a FreeCalypso concoction.
 * Here I set all feature flags to OFF in order to create a configuration
 * that mimics the TCS211 program.
 */

#undef  FF_PS_RSSI
#undef  SIM_PERS
#undef  FF_PHONE_LOCK
#undef  TI_PS_FF_AT_CMD_P_ECC
#undef  TI_PS_FF_REL99_AND_ABOVE
#undef  TI_DUAL_MODE
#undef  REL99
#undef  FF_BHO
#undef  TI_PS_FF_EMR
#undef  TI_PS_FF_RTD
#undef  FF_EGPRS
#undef  REL4
#undef  TI_PS_FF_TBF_EST_PACCH
#undef  TI_PS_FF_QUAD_BAND_SUPPORT