FreeCalypso > hg > fc-tourmaline

view src/g23m-gprs/upm/upm_sndcp_control.h @ 220:0ed36de51973

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
ABB semaphore protection overhaul The ABB semaphone protection logic that came with TCS211 from TI was broken in several ways: * Some semaphore-protected functions were called from Application_Initialize() context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with NU_INVALID_SUSPEND in this context, but the return value wasn't checked, and NU_Release_Semaphore() would be called unconditionally at the end. The latter call would increment the semaphore count past 1, making the semaphore no longer binary and thus no longer effective for resource protection. The fix is to check the return value from NU_Obtain_Semaphore() and skip the NU_Release_Semaphore() call if the semaphore wasn't properly obtained. * Some SPI hardware manipulation was being done before entering the semaphore- protected critical section. The fix is to reorder the code: first obtain the semaphore, then do everything else. * In the corner case of L1/DSP recovery, l1_abb_power_on() would call some non-semaphore-protected ABB & SPI init functions. The fix is to skip those calls in the case of recovery. * A few additional corner cases existed, all of which are fixed by making ABB semaphore protection 100% consistent for all ABB functions and code paths. There is still one remaining problem of priority inversion: suppose a low- priority task calls an ABB function, and some medium-priority task just happens to preempt right in the middle of that semaphore-protected ABB operation. Then the high-priority SPI task is locked out for a non-deterministic time until that medium-priority task finishes its work and goes back to sleep. This priority inversion problem remains outstanding for now.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 26 Apr 2021 20:55:25 +0000
parents fa8dc04885d8
children
line wrap: on
line source

/*----------------------------------------------------------------------------
|  Project :  3G PS
|  Module  :  UPM
+-----------------------------------------------------------------------------
|             Copyright 2003 Texas Instruments.
|             All rights reserved. 
| 
|             This file is confidential and a trade secret of Texas 
|             Instruments .
|             The receipt of or possession of this file does not convey 
|             any rights to reproduce or disclose its contents or to 
|             manufacture, use, or sell anything it may describe, in 
|             whole, or in part, without the specific written consent of 
|             Texas Instruments. 
+-----------------------------------------------------------------------------
| Purpose:    SNDCP Control state machine definitions in the UPM entity.
|             For design details, see:
|             8010.939 UPM Detailed Specification
+---------------------------------------------------------------------------*/

/*==== DECLARATION CONTROL =================================================*/

#ifndef _UPM_SNDCP_CONTROL_H
#define _UPM_SNDCP_CONTROL_H

/*==== INCLUDES =============================================================*/

#include "upm.h"

/*==== CONSTS ===============================================================*/

/*==== TYPES ================================================================*/
typedef enum
{
  /* Incoming primitives */
  UPM_P_SN_ACTIVATE_CNF,
  UPM_P_SN_DEACTIVATE_CNF,
  UPM_P_SN_MODIFY_CNF,
  UPM_P_SN_STATUS_IND,
  UPM_P_MMPM_SEQUENCE_IND,
  /* Events from Link Control */
  UPM_I_SNDCP_AWAIT_ESTABLISH,
  UPM_I_SNDCP_ESTABLISH_LLC_LINK,
  UPM_I_SNDCP_MODIFY_LLC_LINK,
  UPM_I_SNDCP_RELEASE_LLC_LINK,
  /* Number of events */
  UPM_SNDCP_CONTROL_NUMBER_OF_EVENTS
} T_UPM_SNDCP_CONTROL_EVENT;

typedef enum
{
  UPM_SNDCP_INACTIVE,
  UPM_SNDCP_AWAIT_ACTIVATE,
  UPM_SNDCP_ACTIVATING,
  UPM_SNDCP_ACTIVE,
  UPM_SNDCP_MODIFYING,
  UPM_SNDCP_DEACTIVATING,
  UPM_SNDCP_CONTROL_NUMBER_OF_STATES
} T_UPM_SNDCP_CONTROL_STATE;

/*==== EXPORTS ==============================================================*/
extern void upm_sndcp_control_init(struct T_CONTEXT_DATA *ptr_context_data);

extern void upm_sndcp_control_exit(struct T_CONTEXT_DATA *ptr_context_data);

extern void upm_sndcp_control(struct T_CONTEXT_DATA *ptr_context_data,
			      T_UPM_SNDCP_CONTROL_EVENT event,
			      /*@null@*/ void *data);

extern void upm_sndcp_dispatch_sn_count_cnf      (T_SN_COUNT_CNF *);
extern void upm_sndcp_dispatch_sn_status_ind     (T_SN_STATUS_IND *);
extern void upm_sndcp_dispatch_sn_sequence_cnf   (T_SN_SEQUENCE_CNF *);

extern void upm_sndcp_dispatch_mmpm_sequence_ind (T_MMPM_SEQUENCE_IND *);

extern void upm_sndcp_dispatch_upm_count_req     (T_UPM_COUNT_REQ *);
#endif /* _UPM_SNDCP_CONTROL_H */
/*==== END OF FILE ==========================================================*/